Differential D29798

ixgbe: Clarify variable index usage in ixgbe_mc_filter_apply
ClosedPublic
Actions

Authored by kbowling on Apr 16 2021, 8:50 PM.

Tags

None

Referenced Files

	F147862529: D29798.diff
	Sat, Mar 14, 6:33 AM

	Unknown Object (File)
	Fri, Mar 13, 7:07 AM

	Unknown Object (File)
	Sat, Mar 7, 9:28 AM

	Unknown Object (File)
	Wed, Mar 4, 8:49 PM

	Unknown Object (File)
	Wed, Mar 4, 10:25 AM

	Unknown Object (File)
	Mon, Feb 16, 5:25 AM

	Unknown Object (File)
	Feb 10 2026, 9:16 PM

	Unknown Object (File)
	Feb 8 2026, 12:16 PM

Subscribers

Details

Reviewers

Group Reviewers

Intel Networking

Commits

rG2d8adf9cc000: ixgbe: Clarify index name in ixgbe_mc_filter_apply
rG8209a085c701: ixgbe: Clarify index name in ixgbe_mc_filter_apply
rG21afed4b1d18: ixgbe: Clarify index name in ixgbe_mc_filter_apply

Summary

From @erj "It looks like it would be less confusing to rename "count" to something like "idx", since that's what it's used for in this function."

Applies the same variable name change as e1000 in D29789

Test Plan

N/A

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Apr 16 2021, 8:50 PM

Herald added a subscriber: ae. · View Herald TranscriptApr 16 2021, 8:50 PM

kbowling requested review of this revision.Apr 16 2021, 8:50 PM

erj accepted this revision.Apr 16 2021, 11:14 PM

This revision is now accepted and ready to land.Apr 16 2021, 11:14 PM

Closed by commit rG21afed4b1d18: ixgbe: Clarify index name in ixgbe_mc_filter_apply (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyApr 17 2021, 1:21 AM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG21afed4b1d18: ixgbe: Clarify index name in ixgbe_mc_filter_apply.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG8209a085c701: ixgbe: Clarify index name in ixgbe_mc_filter_apply.Apr 25 2021, 7:44 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG2d8adf9cc000: ixgbe: Clarify index name in ixgbe_mc_filter_apply.Apr 25 2021, 7:47 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

8 lines

Diff 87599

sys/dev/ixgbe/if_ix.c

Loading...