e1000: Restore VF interface random MAC
ClosedPublic
Actions

Authored by kbowling on Apr 15 2021, 6:01 PM.

Details

Reviewers

markj
marius
erj

Group Reviewers

Intel Networking

Commits

rG50cebb6a8596: e1000: Restore VF interface random MAC
rG1a34afa9541e: e1000: Restore VF interface random MAC
rG68a46f11eada: e1000: Restore VF interface random MAC

Summary

Restore rS308429 after the iflib conversion of igb(4). This
reenables random MAC address generation when attaching
to a VF with a zeroed MAC.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253535
Reporter: Balaev PA <mail@void.so>

Test Plan

This patch restores functionality for the submitter in the PR

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling requested review of this revision.Apr 15 2021, 6:01 PM

kbowling created this revision.

markj added inline comments.Apr 15 2021, 6:12 PM

sys/dev/e1000/if_em.c
1064–1074	How does vf_ifp get set?

@markj thanks I missed a hunk of the patch, here's a corrected one

markj accepted this revision.Apr 15 2021, 6:33 PM

This revision is now accepted and ready to land.Apr 15 2021, 6:33 PM

Closed by commit rG68a46f11eada: e1000: Restore VF interface random MAC (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyApr 15 2021, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG68a46f11eada: e1000: Restore VF interface random MAC.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG1a34afa9541e: e1000: Restore VF interface random MAC.Apr 29 2021, 1:22 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG50cebb6a8596: e1000: Restore VF interface random MAC.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

if_em.c

21 lines

Diff 87508

View Options

e1000: Restore VF interface random MACClosedPublicActions