ipfw: do not use sleepable malloc in callout context.
ClosedPublic
Actions

Authored by ae on Apr 15 2021, 12:35 PM.

Details

Reviewers

melifaro
kevans

Group Reviewers

network

Commits

rG5ebfa80f7543: ipfw: do not use sleepable malloc in callout context.
rG29246f2cb0c5: ipfw: do not use sleepable malloc in callout context.
rG9bacbf1ae243: ipfw: do not use sleepable malloc in callout context.

Summary

Use malloc(M_NOWAIT) when hash growing is called from callout.

PR: 255041

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38591
Build 35480: arc lint + arc unit

Event Timeline

ae created this revision.Apr 15 2021, 12:35 PM

ae held this revision as a draft.

Herald added subscribers: melifaro, imp. · View Herald TranscriptApr 15 2021, 12:35 PM

Harbormaster completed remote builds in B38590: Diff 87481.Apr 15 2021, 12:35 PM

ae published this revision for review.Apr 15 2021, 12:37 PM

ae edited the summary of this revision. (Show Details)

ae added reviewers: network, melifaro, kevans.

Fix copy/paste bug.

Harbormaster completed remote builds in B38591: Diff 87482.Apr 15 2021, 12:40 PM

kevans accepted this revision.Apr 15 2021, 1:08 PM

This revision is now accepted and ready to land.Apr 15 2021, 1:08 PM

Thanks!

Thank you for this patch.
I'm applied this patch to 3a248c844 and it works fine.

Closed by commit rG9bacbf1ae243: ipfw: do not use sleepable malloc in callout context. (authored by ae). · Explain WhyApr 16 2021, 7:25 AM

This revision was automatically updated to reflect the committed changes.

ae added a commit: rG9bacbf1ae243: ipfw: do not use sleepable malloc in callout context..

freebsd_igalic.co added a subscriber: freebsd_igalic.co.Apr 16 2021, 7:44 AM

freebsd_igalic.co added inline comments.

sys/netpfil/ipfw/ip_fw_dynamic.c
3224	why is it okay to wait here

ae added inline comments.Apr 16 2021, 8:23 AM

sys/netpfil/ipfw/ip_fw_dynamic.c
3224	It is initialization code, it is called from userland when you are doing kldload, user can wait.

ae added a commit: rG29246f2cb0c5: ipfw: do not use sleepable malloc in callout context..Apr 28 2021, 10:06 AM

ae added a commit: rG5ebfa80f7543: ipfw: do not use sleepable malloc in callout context..

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw_dynamic.c

68 lines

Diff 87482

View Options

sys/netpfil/ipfw/ip_fw_dynamic.c

ipfw: do not use sleepable malloc in callout context.ClosedPublicActions