Page MenuHomeFreeBSD
Differential D29560

pfctl: Use the new DIOCGETRULENV ioctl
ClosedPublic
Actions

Authored by kp on Apr 2 2021, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 12, 3:25 PM
Unknown Object (File)
Sat, Apr 11, 7:43 AM
Unknown Object (File)
Sat, Apr 11, 6:21 AM
Unknown Object (File)
Fri, Apr 3, 10:58 PM
Unknown Object (File)
Fri, Apr 3, 12:05 AM
Unknown Object (File)
Wed, Apr 1, 1:11 AM
Unknown Object (File)
Thu, Mar 26, 6:18 PM
Unknown Object (File)
Mar 12 2026, 3:55 PM
View All Files
Subscribers
imp
takahiro.kurosawa_gmail.com

Details

Reviewers
None
Group Reviewers
network
Commits
rGad208b077153: pfctl: Use the new DIOCGETRULENV ioctl
rGd14cf045873b: pfctl: Use the new DIOCGETRULENV ioctl
rG0d6c8174ef2f: pfctl: Use the new DIOCGETRULENV ioctl
Summary

Create wrapper functions to handle the parsing of the nvlist and move
that code into pfctl_ioctl.c.
At some point this should be moved into a libpfctl.

MFC after: 4 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38406
Build 35295: arc lint + arc unit

Event Timeline

kp created this revision.Apr 2 2021, 6:55 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 2 2021, 6:55 PM
kp requested review of this revision.Apr 2 2021, 6:55 PM
kp added a parent revision: D29559: pf: Implement nvlist variant of DIOCGETRULE.
Harbormaster completed remote builds in B38282: Diff 86762.Apr 2 2021, 6:55 PM
kp added a child revision: D29561: libnv: Build PIC.Apr 2 2021, 6:55 PM
kp mentioned this in D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.Apr 2 2021, 6:59 PM
takahiro.kurosawa_gmail.com added a subscriber: takahiro.kurosawa_gmail.com.Apr 2 2021, 7:52 PM
kp updated this revision to Diff 87026.Apr 8 2021, 12:31 PM

Rebase

  • remove rt_listid
  • Return qid/pqid (which pfctl can display for debugging)
Harbormaster completed remote builds in B38406: Diff 87026.Apr 8 2021, 12:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2021, 9:17 AM
Closed by commit rG0d6c8174ef2f: pfctl: Use the new DIOCGETRULENV ioctl (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG0d6c8174ef2f: pfctl: Use the new DIOCGETRULENV ioctl.
kp added a commit: rGd14cf045873b: pfctl: Use the new DIOCGETRULENV ioctl.May 7 2021, 3:27 PM
kp added a commit: rGad208b077153: pfctl: Use the new DIOCGETRULENV ioctl.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
2 lines
12 lines
43 lines
339 lines
7 lines

Diff 87026

View Options

sbin/pfctl/Makefile

Loading...
View Options

sbin/pfctl/pfctl.c

Loading...
View Options

sbin/pfctl/pfctl_ioctl.h

Loading...
View Options

sbin/pfctl/pfctl_ioctl.c

Loading...
View Options

sbin/pfctl/pfctl_optimize.c

Loading...