Page MenuHomeFreeBSD
Differential D21746

acpi_cros_kblt: New driver for Chromebook keyboard backlight control
Needs ReviewPublic
Actions

Authored by val_packett.cool on Sep 21 2019, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 27, 5:34 PM
Unknown Object (File)
Thu, Feb 26, 6:02 PM
Unknown Object (File)
Thu, Feb 26, 2:25 PM
Unknown Object (File)
Thu, Feb 26, 9:20 AM
Unknown Object (File)
Thu, Feb 26, 7:24 AM
Unknown Object (File)
Mon, Feb 23, 11:03 PM
Unknown Object (File)
Thu, Feb 19, 7:46 PM
Unknown Object (File)
Tue, Feb 17, 3:41 AM
View All Files
Subscribers
dmitryluhtionov_gmail.com
emaste
imp

Details

Reviewers
imp
manu
Group Reviewers
Contributor Reviews (src)
desktop
Summary

Allows adjusting keyboard backlight level on amd64 Chromebooks, restores it on resume from sleep.

Sponsored by: https://www.patreon.com/valpackett
Test Plan

Tested on: Google Pixelbook (eve)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

val_packett.cool created this revision.Sep 21 2019, 10:02 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 21 2019, 10:02 PM
imp accepted this revision.Sep 21 2019, 10:15 PM

I was going to suggest adding the devmatch changes, but no other ACPI driver seems to have them yet, so I can do that in a sweep.

This revision is now accepted and ready to land.Sep 21 2019, 10:15 PM
val_packett.cool added a comment.Sep 22 2019, 11:06 AM

Yeah, I was wondering about devmatch in D21612

val_packett.cool mentioned this in D26250: Add backlight subsystem.Sep 4 2020, 5:19 PM
val_packett.cool updated this revision to Diff 86640.Mar 31 2021, 7:02 PM
val_packett.cool edited the summary of this revision. (Show Details)
val_packett.cool added a reviewer: manu.
  • Use backlight(9) subsystem
  • Add SPDX tag
  • Some formatting changes

@imp how's the ACPI devmatch work? :)

This revision now requires review to proceed.Mar 31 2021, 7:02 PM
val_packett.cool updated this revision to Diff 86641.Mar 31 2021, 7:03 PM

Oops, with git now, we don't need $FreeBSD$ in the Makefile either

imp added a comment.May 23 2021, 8:30 PM

Man page?

val_packett.cool updated this revision to Diff 116458.Feb 4 2023, 7:13 AM

Add man page and sys/conf/files entry

Harbormaster completed remote builds in B49520: Diff 116458.Feb 4 2023, 7:13 AM
val_packett.cool edited the summary of this revision. (Show Details)Feb 4 2023, 7:13 AM
val_packett.cool added a reviewer: desktop.
emaste added a subscriber: emaste.Feb 6 2023, 6:18 PM
dmitryluhtionov_gmail.com added a subscriber: dmitryluhtionov_gmail.com.Mar 2 2023, 11:52 AM

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

val_packett.cool added a comment.Mar 2 2023, 4:31 PM
In D21746#884483, @dmitryluhtionov_gmail.com wrote:

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

That's not a kernel thing, that can't be done *here*. upowerd needs integration with the backlight(9) system. But I think backlight(9) currently doesn't have event notifications. I'll look into that, but that's unrelated to drivers for particular hardware :)

Revision Contents
Changeset List

PathSize
sys/
dev/
acpi_support/
174 lines
modules/
acpi/
acpi_cros_kblt/
5 lines

Diff 86641

View Options

sys/dev/acpi_support/acpi_cros_kblt.c

Loading...
View Options

sys/modules/acpi/acpi_cros_kblt/Makefile

Loading...