Differential D29095

lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped
ClosedPublic
Actions

Authored by arichardson on Mar 5 2021, 4:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 14, 10:41 PM

	Unknown Object (File)
	Tue, May 14, 10:41 PM

	Unknown Object (File)
	Tue, May 14, 10:41 PM

	Unknown Object (File)
	Tue, May 14, 10:29 PM

	Unknown Object (File)
	Wed, May 8, 2:56 PM

	Unknown Object (File)
	Apr 17 2024, 9:59 PM

	Unknown Object (File)
	Apr 17 2024, 7:07 PM

	Unknown Object (File)
	Feb 2 2024, 2:26 AM

View All 58 Files

Subscribers

Details

Reviewers

ngie
dim
andrew
lwhsu

Commits

rG1f7e87f2d322: lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped
rG2b9dbcd390df: lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped

Summary

Some CPUs (e.g. AArch64 QEMU) cannot trap on floating point exceptions and
therefore ignore the writes to the floating point control register inside
feenableexcept(). If no exceptions are enabled after
feenableexcept(FE_ALL_EXCEPT), we can assume that the CPU does not
support exceptions and we can then skip the test.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Mar 5 2021, 4:47 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 5 2021, 4:47 PM

arichardson requested review of this revision.Mar 5 2021, 4:47 PM

Harbormaster completed remote builds in B37618: Diff 85224.Mar 5 2021, 4:47 PM

arichardson added a parent revision: D28798: Convert the msun tests to ATF.Mar 5 2021, 4:48 PM

Looks like a good idea to me.

This revision is now accepted and ready to land.Mar 5 2021, 8:45 PM

Closed by commit rG2b9dbcd390df: lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped (authored by arichardson). · Explain WhyMar 22 2021, 12:01 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG2b9dbcd390df: lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped.

arichardson added a commit: rG1f7e87f2d322: lib/msun/tests: Skip fenv_test:masking if exceptions can't be trapped.Apr 22 2021, 11:09 AM

Revision Contents
Changeset List

Path

Size

lib/

msun/

tests/

22 lines

Diff 86139

lib/msun/tests/fenv_test.c

Loading...