pf: pool/kpool conversion code
ClosedPublic
Actions

Authored by kp on Mar 11 2021, 10:42 AM.

Details

Reviewers

Group Reviewers

Commits

rG7d5886158650: pf: pool/kpool conversion code
rG961e7887b9ba: pf: pool/kpool conversion code
rG15b82e00a164: pf: pool/kpool conversion code

Summary

stuct pf_pool and struct pf_kpool are different. We should not simply
bcopy() them.

Happily it turns out that their differences were all pointers, and the
userspace provided pointers were overwritten by the kernel, so this did
actually work correctly, but we should fix it anyway.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 11 2021, 10:42 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMar 11 2021, 10:42 AM

kp requested review of this revision.Mar 11 2021, 10:42 AM

Harbormaster completed remote builds in B37768: Diff 85564.Mar 11 2021, 10:42 AM

glebius accepted this revision.Mar 15 2021, 8:03 PM

This revision is now accepted and ready to land.Mar 15 2021, 8:03 PM

Closed by commit rG15b82e00a164: pf: pool/kpool conversion code (authored by kp). · Explain WhyMar 16 2021, 10:11 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG15b82e00a164: pf: pool/kpool conversion code.

kp added a commit: rG961e7887b9ba: pf: pool/kpool conversion code.Mar 23 2021, 12:24 PM

kp added a commit: rG7d5886158650: pf: pool/kpool conversion code.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

39 lines

Diff 85824

View Options

pf: pool/kpool conversion codeClosedPublicActions