efifb,vbefb: implement vd_fini
ClosedPublic
Actions

Authored by val_packett.cool on Mar 2 2021, 9:00 PM.

Details

Reviewers

manu
tsoome
emaste

Group Reviewers

Contributor Reviews (src)

Commits

rGae4067ce9414: efifb,vbefb: implement vd_fini
rG8ebda6e44bb6: efifb,vbefb: implement vd_fini

Summary

This removes the pmap entry when switching away to e.g. drm fb.

Not strictly necessary to remove the mapping — avoiding conflicts (https://github.com/freebsd/drm-kmod/issues/60) is about avoiding *touching* the memory — but it's still nice to clean up.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

val_packett.cool created this revision.Mar 2 2021, 9:00 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 2 2021, 9:00 PM

val_packett.cool requested review of this revision.Mar 2 2021, 9:00 PM

Harbormaster completed remote builds in B37514: Diff 85000.Mar 2 2021, 9:01 PM

val_packett.cool edited the summary of this revision. (Show Details)Mar 2 2021, 9:02 PM

val_packett.cool added reviewers: Contributor Reviews (src), manu, tsoome, emaste.

val_packett.cool changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

You want to add the same to vbefb.

manu accepted this revision.Mar 3 2021, 7:16 AM

This revision is now accepted and ready to land.Mar 3 2021, 7:16 AM

Added vbefb (not tested)

This revision now requires review to proceed.Mar 9 2021, 12:35 PM

tsoome accepted this revision.Mar 9 2021, 12:38 PM

This revision is now accepted and ready to land.Mar 9 2021, 12:38 PM

@tsoome will you commit?

In D29020#655696, @emaste wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

In D29020#655703, @manu wrote:

In D29020#655696, @emaste wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.