Page MenuHomeFreeBSD
Differential D29020

efifb,vbefb: implement vd_fini
ClosedPublic
Actions

Authored by val_packett.cool on Mar 2 2021, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 24, 2:02 PM
Unknown Object (File)
Fri, May 22, 4:52 PM
Unknown Object (File)
Fri, May 22, 5:34 AM
Unknown Object (File)
Mon, May 18, 12:54 PM
Unknown Object (File)
Fri, May 15, 8:12 PM
Unknown Object (File)
Tue, Apr 28, 12:28 PM
Unknown Object (File)
Apr 26 2026, 12:37 AM
Unknown Object (File)
Apr 23 2026, 3:24 AM
View All Files
Subscribers
imp
pstef
Contributor Reviews (src)

Details

Reviewers
manu
tsoome
emaste
Group Reviewers
Contributor Reviews (src)
Commits
rGae4067ce9414: efifb,vbefb: implement vd_fini
rG8ebda6e44bb6: efifb,vbefb: implement vd_fini
Summary

This removes the pmap entry when switching away to e.g. drm fb.

Not strictly necessary to remove the mapping — avoiding conflicts (https://github.com/freebsd/drm-kmod/issues/60) is about avoiding *touching* the memory — but it's still nice to clean up.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37514
Build 34403: arc lint + arc unit

Event Timeline

val_packett.cool created this revision.Mar 2 2021, 9:00 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 2 2021, 9:00 PM
val_packett.cool requested review of this revision.Mar 2 2021, 9:00 PM
Harbormaster completed remote builds in B37514: Diff 85000.Mar 2 2021, 9:01 PM
val_packett.cool edited the summary of this revision. (Show Details)Mar 2 2021, 9:02 PM
val_packett.cool added reviewers: Contributor Reviews (src), manu, tsoome, emaste.
val_packett.cool changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
tsoome added a comment.Mar 2 2021, 9:11 PM

You want to add the same to vbefb.

manu accepted this revision.Mar 3 2021, 7:16 AM
This revision is now accepted and ready to land.Mar 3 2021, 7:16 AM
val_packett.cool updated this revision to Diff 85386.Mar 9 2021, 12:35 PM
val_packett.cool retitled this revision from efifb: implement vd_fini to efifb,vbefb: implement vd_fini.
val_packett.cool edited the summary of this revision. (Show Details)

Added vbefb (not tested)

This revision now requires review to proceed.Mar 9 2021, 12:35 PM
tsoome accepted this revision.Mar 9 2021, 12:38 PM
This revision is now accepted and ready to land.Mar 9 2021, 12:38 PM
emaste added a comment.Mar 16 2021, 3:12 AM

@tsoome will you commit?

manu added a comment.Mar 16 2021, 5:55 AM
In D29020#655696, @emaste wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

tsoome added a comment.Mar 16 2021, 7:01 AM
In D29020#655703, @manu wrote:
In D29020#655696, @emaste wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

ACK.

val_packett.cool added a comment.Mar 30 2021, 1:30 PM

ping

pstef added a subscriber: pstef.Mar 30 2021, 1:52 PM
pstef added inline comments.
sys/dev/vt/hw/efifb/efifb.c
154

style nit: double space

sys/dev/vt/hw/vbefb/vbefb.c
160 ↗(On Diff #85386)

style nit: double space

Closed by commit rG8ebda6e44bb6: efifb,vbefb: implement vd_fini (authored by val_packett.cool, committed by manu). · Explain WhyMar 30 2021, 3:48 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG8ebda6e44bb6: efifb,vbefb: implement vd_fini.
manu added a commit: rGae4067ce9414: efifb,vbefb: implement vd_fini.Jan 14 2022, 4:10 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
hw/
efifb/
11 lines

Diff 85000

View Options

sys/dev/vt/hw/efifb/efifb.c

Loading...