Page MenuHomeFreeBSD
Differential D28888

Remove atf_tc_skip calls from ptrace_test
ClosedPublic
Actions

Authored by arichardson on Feb 23 2021, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 12, 1:53 AM
Unknown Object (File)
Wed, May 8, 10:19 PM
Unknown Object (File)
Wed, May 8, 12:31 AM
Unknown Object (File)
Fri, Apr 26, 2:25 PM
Unknown Object (File)
Tue, Apr 23, 7:35 AM
Unknown Object (File)
Apr 19 2024, 4:18 PM
Unknown Object (File)
Apr 17 2024, 8:21 PM
Unknown Object (File)
Apr 17 2024, 2:12 AM
View All 48 Files
Subscribers
emaste
imp

Details

Reviewers
lwhsu
jhb
markj
Commits
rG80c34bad1979: Remove atf_tc_skip calls from ptrace_test
rG1032131464f1: Remove atf_tc_skip calls from ptrace_test
Summary

I've run this tests many times in a loop and it works reliably for me,
maybe it's time to retire these skips?
This also adds an additional waitpid to one of the tests to avoid
a potential race condition (suggested by markj@).

PR: 239397, 244056, 239425, 240510, 220841, 243605

Test Plan

works fine on QEMU.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Feb 23 2021, 12:40 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 23 2021, 12:40 PM
arichardson requested review of this revision.Feb 23 2021, 12:40 PM
Harbormaster completed remote builds in B37302: Diff 84531.Feb 23 2021, 12:41 PM
emaste added a comment.Feb 23 2021, 2:22 PM

I believe we've seen cases where tests fail in CI but pass regularly when run locally; not sure if that's the case for these tests but if we do re-enable them in CI we will need to watch closely and be ready to disable them again.

markj added a comment.Feb 23 2021, 2:43 PM

I don't recall ever seeing these failures myself, so indeed, I suspect there's something particular to the CI environment that causes these tests to fail. I support re-enabling them to verify that that's the case though.

arichardson added inline comments.Feb 23 2021, 2:45 PM
tests/sys/kern/ptrace_test.c
4222

This one does look like it could be flaky since there is no pipe() call to synchronized between parent and child, but otherwise they all seem like they shouldn't fail.

markj added inline comments.Feb 24 2021, 3:26 PM
tests/sys/kern/ptrace_test.c
4222

You mean, the second child may attach before the first one has raised SIGSTOP?

arichardson added inline comments.Feb 24 2021, 3:28 PM
tests/sys/kern/ptrace_test.c
4222

Yes, I think that could theoretically happen here.

jhb added a comment.Feb 25 2021, 7:54 PM

I've never been able to reproduce the issues that CI previously reported for most of these. :(

markj added inline comments.Feb 25 2021, 7:58 PM
tests/sys/kern/ptrace_test.c
4222

Shouldn't it be sufficient to add

waitpid(traced, &status, WSTOPPED);

before the fork() call?

arichardson updated this revision to Diff 84713.Feb 25 2021, 8:48 PM
arichardson marked 2 inline comments as done.

Add the suggested waitpid. All previously-skipped tests pass reliably for me.

Harbormaster completed remote builds in B37385: Diff 84713.Feb 25 2021, 8:48 PM
arichardson edited the summary of this revision. (Show Details)Feb 25 2021, 9:16 PM
markj accepted this revision.Feb 26 2021, 2:19 PM
This revision is now accepted and ready to land.Feb 26 2021, 2:19 PM
arichardson added a parent revision: D28887: ptrace_test: Add more debug output on test failures.Mar 1 2021, 2:29 PM
Closed by commit rG1032131464f1: Remove atf_tc_skip calls from ptrace_test (authored by arichardson). · Explain WhyMar 1 2021, 7:57 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG1032131464f1: Remove atf_tc_skip calls from ptrace_test.
arichardson added a commit: rG80c34bad1979: Remove atf_tc_skip calls from ptrace_test.Mar 17 2021, 2:06 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
29 lines

Diff 84919

View Options

tests/sys/kern/ptrace_test.c

Loading...