Page MenuHomeFreeBSD

Allow ssp_test:read to pass more reliably
ClosedPublic

Authored by arichardson on Mar 1 2021, 2:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:40 AM
Unknown Object (File)
Tue, Sep 30, 1:39 AM
Unknown Object (File)
Sat, Sep 27, 7:16 PM
Unknown Object (File)
Sat, Sep 27, 7:12 PM
Unknown Object (File)
Wed, Sep 24, 4:44 PM
Unknown Object (File)
Thu, Sep 18, 2:58 AM
Unknown Object (File)
Sep 4 2025, 7:33 PM
Unknown Object (File)
Aug 19 2025, 9:20 AM
Subscribers

Details

Summary

It appears that the stackframe layout can be slightly different depending on
compiler and target architecture. For example, when using CHERI LLVM for RISC-V
we can actually overflow the buffer by up to 8 bytes without SSP detecting it.
Fix this by increasing the overflow to 15 bytes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37477
Build 34366: arc lint + arc unit

Event Timeline

I think this is reasonable. I don't think we care whether SSP detects a stack overflow that overwrites only padding.

This revision is now accepted and ready to land.Mar 1 2021, 3:36 PM
contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh
397

I wonder if this consistently works on NetBSD?

contrib/netbsd-tests/lib/libc/ssp/t_ssp.sh
397

Unlikely.