bridge: Support STP on VLAN devices
ClosedPublic
Actions

Authored by kp on Feb 22 2021, 2:32 PM.

Details

Reviewers

Group Reviewers

Commits

rG02a34c9198d2: bridge: Support STP on VLAN devices
rGc3438a8438fe: bridge: Support STP on VLAN devices
rG711ed156b945: bridge: Support STP on VLAN devices

Summary

VLAN devices have type IFT_L2VLAN, so the STP code mistakenly believed
they couldn't be used for STP. That's not the case, so add the
ITF_L2VLAN to the check.

MFC after: 1 week
Sponsored by: Orange Business Services

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37266
Build 34155: arc lint + arc unit

Event Timeline

kp created this revision.Feb 22 2021, 2:32 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 22 2021, 2:32 PM

kp requested review of this revision.Feb 22 2021, 2:32 PM

Harbormaster completed remote builds in B37266: Diff 84452.Feb 22 2021, 2:32 PM

kp added a child revision: D28858: bridge/stp: Ensure we enter NET_EPOCH whenever we can send traffic.Feb 22 2021, 2:34 PM

This will result in STP over Vlan (or PVST ala Cisco) if applied to vlan interfaces.
LTGM

This revision is now accepted and ready to land.Feb 22 2021, 5:48 PM

Closed by commit rG711ed156b945: bridge: Support STP on VLAN devices (authored by kp). · Explain WhyFeb 23 2021, 1:55 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG711ed156b945: bridge: Support STP on VLAN devices.

kp added a commit: rGc3438a8438fe: bridge: Support STP on VLAN devices.Mar 2 2021, 3:18 PM

kp added a commit: rG02a34c9198d2: bridge: Support STP on VLAN devices.

Revision Contents
Changeset List

Path

Size

sys/

net/

bridgestp.c

1 line

Diff 84452

View Options

bridge: Support STP on VLAN devicesClosedPublicActions