ibnd_*(3): fix source of manpage
ClosedPublic
Actions

Authored by fernape on Feb 17 2021, 2:25 PM.

Details

Reviewers

0mp
gbe
yuripv

Group Reviewers

manpages

Commits

rG0577e39bec76: Fix ibnd_* manpages sources

Summary

Some ibnd_* manpages source other manpages from a man3/ directory when it should
reference the pages in the current directory.

PR: 237693
Reported by: wosch@FreeBSD.org

Test Plan

$ man ibnd_debug

This is what you get:

()                                                                          ()




See the file ibnd_discover_fabric.3.




                               February 17, 2021                            ()
(END)

This was tested in 12.2-RELEASE and 13-stable

After aplying the patch

$ cd lib/ofed/libibnetdisc && make
$ man ./ibnd_debug.3.gz

It shows expected results.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37093
Build 33982: arc lint + arc unit

Event Timeline

fernape created this revision.Feb 17 2021, 2:25 PM

Herald added a reviewer: manpages. · View Herald TranscriptFeb 17 2021, 2:25 PM

Herald added a subscriber: imp. · View Herald Transcript

fernape requested review of this revision.Feb 17 2021, 2:25 PM

Harbormaster completed remote builds in B37092: Diff 84083.Feb 17 2021, 2:25 PM

I'd rather not modify the contrib source, skip installing these, and use MLINKS instead.

Address comments by yuripv@

Do not install affected pages
Use MLINKS instead of fixing the .so macro (discouraged by mandoc(1))

Test plan:

Apply the patch and then:

$ cd lib/ofed/libibnetdisc && make install
...
...
$ man ibnd_debug
$ man ibnd_destroy_fabric
$ man ibnd_iter_nodes_type
$ man ibnd_find_node_dr
$ man ibnd_show_progress