linux: Unmap the VDSO page when unloading
ClosedPublic
Actions

Authored by markj on Feb 15 2021, 11:45 PM.

Details

Reviewers

manu
trasz
kib

Commits

rG3df2766a6916: linux: Unmap the VDSO page when unloading
rG0fc8a7967228: linux: Unmap the VDSO page when unloading

Summary

linux_shared_page_init() creates an object and grabs and maps a single
page to back the VDSO. When destroying the VDSO object, we failed to
destroy the mapping and free KVA.

Test Plan

Load and unload linux.ko and linux64.ko.

Noticed when working on Jeff's vm_object patches.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 15 2021, 11:45 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 15 2021, 11:45 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

markj requested review of this revision.Feb 15 2021, 11:45 PM

Harbormaster completed remote builds in B37042: Diff 83980.Feb 15 2021, 11:46 PM

markj edited the test plan for this revision. (Show Details)Feb 15 2021, 11:46 PM

markj added reviewers: trasz, kib.

kib accepted this revision.Feb 16 2021, 1:42 AM

This revision is now accepted and ready to land.Feb 16 2021, 1:42 AM

Closed by commit rG0fc8a7967228: linux: Unmap the VDSO page when unloading (authored by markj). · Explain WhyFeb 16 2021, 2:40 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0fc8a7967228: linux: Unmap the VDSO page when unloading.

https://ci.freebsd.org/job/FreeBSD-main-i386-build/19172/console shows:

13:07:49 --- all_subdir_linux ---
13:07:49 /usr/src/sys/i386/linux/linux_sysvec.c:941:54: error: too few arguments to function call, expected 2, have 1
13:07:49 __elfN(linux_shared_page_fini)(linux_shared_page_obj);
13:07:49 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

In D28696#642861, @markmi_dsl-only.net wrote:

https://ci.freebsd.org/job/FreeBSD-main-i386-build/19172/console shows:

13:07:49 --- all_subdir_linux ---
13:07:49 /usr/src/sys/i386/linux/linux_sysvec.c:941:54: error: too few arguments to function call, expected 2, have 1
13:07:49 __elfN(linux_shared_page_fini)(linux_shared_page_obj);
13:07:49 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

Thanks, fixed.

markj added a commit: rG3df2766a6916: linux: Unmap the VDSO page when unloading.Feb 23 2021, 1:31 AM