Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check
ClosedPublic
Actions

Authored by arichardson on Feb 15 2021, 8:25 PM.

Details

Reviewers

Group Reviewers

Commits

rG4edea0540344: Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check
rG0482d7c9e944: Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check

Summary

After eaad8d1303da500ed691bd774742a4555a05e729 four additional
capsicum-test tests started failing. It turns out this is because
fget_only_user() was returning EBADF on a failed capsicum check instead
of forwarding the return value of cap_check_inline() like
fget_unlocked_seq().

Test Plan

capsicum-test failures before this:

[  FAILED  ] 7 tests, listed below:
[  FAILED  ] Capability.OperationsForked
[  FAILED  ] Capability.NoBypassDAC
[  FAILED  ] Pdfork.OtherUserForked
[  FAILED  ] PipePdfork.WildcardWait
[  FAILED  ] OpenatTest.WithFlag
[  FAILED  ] ForkedOpenatTest_WithFlagInCapabilityMode._
[  FAILED  ] Select.LotsOFileDescriptorsForked

After:

[  FAILED  ] 3 tests, listed below:
[  FAILED  ] Capability.NoBypassDAC
[  FAILED  ] Pdfork.OtherUserForked
[  FAILED  ] PipePdfork.WildcardWait

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37034
Build 33923: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 15 2021, 8:25 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 15 2021, 8:25 PM

Harbormaster completed remote builds in B37034: Diff 83958.Feb 15 2021, 8:25 PM

arichardson requested review of this revision.Feb 15 2021, 8:25 PM

mjg accepted this revision.Feb 15 2021, 8:44 PM

This revision is now accepted and ready to land.Feb 15 2021, 8:44 PM

Closed by commit rG0482d7c9e944: Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check (authored by arichardson). · Explain WhyFeb 15 2021, 10:56 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG0482d7c9e944: Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check.

arichardson added a commit: rG4edea0540344: Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check.Mar 17 2021, 10:28 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_descrip.c

2 lines

Diff 83958

View Options

Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum checkClosedPublicActions