Page MenuHomeFreeBSD
Differential D28655

ifconfig-wg fix incorrect allowed-ips netmask info
ClosedPublic
Actions

Authored by nyan_myuji.xyz on Feb 13 2021, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 28, 5:05 AM
Unknown Object (File)
Fri, Dec 19, 11:20 PM
Unknown Object (File)
Sat, Dec 13, 8:28 PM
Unknown Object (File)
Mon, Dec 8, 12:54 PM
Unknown Object (File)
Wed, Dec 3, 10:10 PM
Unknown Object (File)
Mon, Dec 1, 5:43 PM
Unknown Object (File)
Mon, Dec 1, 11:27 AM
Unknown Object (File)
Nov 28 2025, 3:08 PM
View All Files
Subscribers
imp
khng
Contributor Reviews (src)

Details

Reviewers
grehan
mmacy
Group Reviewers
network
Commits
rGf28545524cb1: ifconfig: fix incorrect wg allowed-ips netmask
rG0646b83f0779: ifconfig: fix incorrect wg allowed-ips netmask
rGbe2003ccfa1b: ifconfig: fix incorrect wg allowed-ips netmask
Summary

Currently when peer information being dumped via ifconfig wgN peer ..
or ifconfig wgN peer-list, whichever the netmask of the first allowed-ips
will be used as the netmask of all CIDR in allowed-ips. For example, if the
list is 192.168.1.0/24, 172.16.0.0/16, it will display as
192.168.1.0/24, 172.16.0.0/24. While this does not affects the actual functionality,
it creates massive confusion for users.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36979
Build 33868: arc lint + arc unit

Event Timeline

nyan_myuji.xyz created this revision.Feb 13 2021, 11:39 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 13 2021, 11:39 PM
nyan_myuji.xyz requested review of this revision.Feb 13 2021, 11:39 PM
Harbormaster completed remote builds in B36979: Diff 83853.Feb 13 2021, 11:39 PM
nyan_myuji.xyz added a comment.Feb 13 2021, 11:42 PM

Related bugzillla ticket: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253487

kp added reviewers: grehan, mmacy, network.Feb 14 2021, 8:14 AM
grehan accepted this revision.Feb 14 2021, 8:34 AM
This revision is now accepted and ready to land.Feb 14 2021, 8:34 AM
khng added a subscriber: khng.Feb 14 2021, 8:59 AM

This works for me.

Closed by commit rGbe2003ccfa1b: ifconfig: fix incorrect wg allowed-ips netmask (authored by nyan_myuji.xyz, committed by philip). · Explain WhyFeb 15 2021, 2:40 AM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rGbe2003ccfa1b: ifconfig: fix incorrect wg allowed-ips netmask.
philip added a commit: rG0646b83f0779: ifconfig: fix incorrect wg allowed-ips netmask.Feb 16 2021, 2:12 AM
philip added a commit: rGf28545524cb1: ifconfig: fix incorrect wg allowed-ips netmask.Feb 16 2021, 9:14 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
2 lines

Diff 83853

View Options

sbin/ifconfig/ifwg.c

Loading...