Page MenuHomeFreeBSD
Differential D28550

libpmc: fix linking with C programs
ClosedPublic
Actions

Authored by asomers on Feb 9 2021, 4:03 AM.
Tags
None
Referenced Files
F162809049: D28550.diff
Fri, Jul 17, 3:14 AM
Unknown Object (File)
Sun, Jul 5, 10:50 PM
Unknown Object (File)
Thu, Jul 2, 8:54 PM
Unknown Object (File)
Tue, Jun 30, 8:23 PM
Unknown Object (File)
Tue, Jun 23, 12:47 AM
Unknown Object (File)
Sun, Jun 21, 1:56 AM
Unknown Object (File)
Jun 4 2026, 2:32 PM
Unknown Object (File)
Jun 4 2026, 2:26 PM
View All Files
Subscribers
imp

Details

Reviewers
mmacy
vangyzen
Commits
rG9c59d7533731: libpmc: fix linking with C programs
rG26b11d047d20: libpmc: fix linking with C programs
rG418d29545e0b: libpmc: fix linking with C programs
rGced29ea4fb42: libpmc: fix linking with C programs
rG04e34c0202ea: libpmc: fix linking with C programs
Summary

Revision r334749 Added some C++ code to libpmc. It didn't change the ABI,
but it did introduce a dependency on libc++. Nobody noticed because every
program that in the base system that uses libpmc is also C++.

Reported-by: Dom Dwyer <dom@itsallbroken.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36824
Build 33713: arc lint + arc unit

Event Timeline

asomers created this revision.Feb 9 2021, 4:03 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 9 2021, 4:03 AM
asomers requested review of this revision.Feb 9 2021, 4:03 AM
Harbormaster completed remote builds in B36824: Diff 83579.Feb 9 2021, 4:03 AM
vangyzen accepted this revision.Feb 15 2021, 10:01 PM
This revision is now accepted and ready to land.Feb 15 2021, 10:01 PM
Closed by commit rG04e34c0202ea: libpmc: fix linking with C programs (authored by asomers). · Explain WhyFeb 15 2021, 10:55 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG04e34c0202ea: libpmc: fix linking with C programs.
asomers added a commit: rGced29ea4fb42: libpmc: fix linking with C programs.Feb 20 2021, 12:37 AM
asomers added a commit: rG418d29545e0b: libpmc: fix linking with C programs.Feb 20 2021, 12:45 AM
asomers added a reverting change: rGde8d66b37823: Revert "libpmc: fix linking with C programs".Feb 20 2021, 3:26 AM
asomers added a commit: rG26b11d047d20: libpmc: fix linking with C programs.Feb 21 2021, 8:43 PM
asomers added a commit: rG9c59d7533731: libpmc: fix linking with C programs.Feb 22 2021, 5:24 AM

Revision Contents
Changeset List

PathSize
lib/
libpmc/
1 line

Diff 83579

View Options

lib/libpmc/Makefile

Loading...