iscsi: Mark iSCSI CAM sims as non-pollable.
ClosedPublic
Actions

Authored by jhb on Feb 1 2021, 11:32 PM.

Details

Reviewers

mav
imp
scottl

Commits

rG47769bc5573f: iscsi: Mark iSCSI CAM sims as non-pollable.

Summary

Previously, iscsi_poll() just panicked. This meant if you got a panic
on a box when using the iSCSI initiator, the attempt to shutdown would
trigger a nested panic and never write out a core. Now, CCB's sent to
iSCSI devices (such as the sychronize-cache request in dashutdown())
just fail with a timeout during a panic shutdown.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36664
Build 33553: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Feb 1 2021, 11:32 PM

jhb created this revision.

Harbormaster completed remote builds in B36664: Diff 83251.Feb 1 2021, 11:32 PM

jhb added a parent revision: D28454: cam: Don't permit crashdumps on non-pollable devices..Feb 1 2021, 11:32 PM

Somebody will need to go through the tree and update other alike drivers, which should be plenty.

This revision is now accepted and ready to land.Feb 1 2021, 11:44 PM

We can't get the status for the dasync stuff, but it will still be sent... Is that really a timeout error?

In D28455#636682, @imp wrote:

We can't get the status for the dasync stuff, but it will still be sent... Is that really a timeout error?

Without scheduler active request won't even be sent, since it is handled by different thread. Plus it need to allocate some memory, which is bad if we are in panic, since it may corrupt the dump.

In D28455#636684, @mav wrote:

In D28455#636682, @imp wrote:

We can't get the status for the dasync stuff, but it will still be sent... Is that really a timeout error?

Without scheduler active request won't even be sent, since it is handled by different thread. Plus it need to allocate some memory, which is bad if we are in panic, since it may corrupt the dump.

All true. Does the iscsi action routine cope? We call it higher up in the stack... other sims might be able to do something, but not get status back. Though that is largely theoretical.

scottl accepted this revision.Feb 2 2021, 4:50 AM

In D28455#636687, @imp wrote:

In D28455#636684, @mav wrote:

In D28455#636682, @imp wrote:

We can't get the status for the dasync stuff, but it will still be sent... Is that really a timeout error?

Without scheduler active request won't even be sent, since it is handled by different thread. Plus it need to allocate some memory, which is bad if we are in panic, since it may corrupt the dump.

All true. Does the iscsi action routine cope? We call it higher up in the stack... other sims might be able to do something, but not get status back. Though that is largely theoretical.

See my comment in the other review. cam_periph_runccb() doesn't call xpt_action() for a polled request with this set of changes, so iscsi_action() will never "see" a polled ccb.

Closed by commit rG47769bc5573f: iscsi: Mark iSCSI CAM sims as non-pollable. (authored by jhb). · Explain WhyFeb 11 2021, 9:53 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG47769bc5573f: iscsi: Mark iSCSI CAM sims as non-pollable..