Page MenuHomeFreeBSD
Differential D28454

cam: Don't permit crashdumps on non-pollable devices.
ClosedPublic
Actions

Authored by jhb on Feb 1 2021, 11:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 14, 10:18 PM
Unknown Object (File)
Thu, Aug 14, 11:18 AM
Unknown Object (File)
Jun 26 2025, 2:08 AM
Unknown Object (File)
Jun 21 2025, 5:06 AM
Unknown Object (File)
Jun 12 2025, 3:51 PM
Unknown Object (File)
Jun 2 2025, 4:23 AM
Unknown Object (File)
May 14 2025, 3:35 PM
Unknown Object (File)
Apr 26 2025, 3:51 PM
View All 85 Files
Subscribers
dab
cam

Details

Reviewers
mav
imp
scottl
Group Reviewers
cam
Commits
rGe07ac3f2fd73: cam: Don't permit crashdumps on non-pollable devices.
Summary

If a disk's SIM doesn't support polling, then it can't be used to
store crashdumps. Leave d_dump NULL in that case so that dumpon(8)
fails gracefully rather than having dumps fail at crash time.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36663
Build 33552: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 1 2021, 11:32 PM
Herald added a reviewer: cam. · View Herald TranscriptFeb 1 2021, 11:32 PM
Herald added a subscriber: dab. · View Herald Transcript
Harbormaster completed remote builds in B36663: Diff 83250.Feb 1 2021, 11:32 PM
jhb requested review of this revision.Feb 1 2021, 11:32 PM
jhb added a parent revision: D28453: cam: Permit non-pollable sims..
jhb added a child revision: D28455: iscsi: Mark iSCSI CAM sims as non-pollable..
imp accepted this revision.Feb 1 2021, 11:35 PM

I'm happy with this, but all nvme SIMs support polling... But the change isn't wrong, we'll just never fail to take the if into setting d_dump.

sys/cam/nvme/nvme_da.c
901

All nvme sims support polling...

This revision is now accepted and ready to land.Feb 1 2021, 11:35 PM
mav accepted this revision.Feb 1 2021, 11:42 PM
scottl accepted this revision.Feb 2 2021, 4:39 AM
Closed by commit rGe07ac3f2fd73: cam: Don't permit crashdumps on non-pollable devices. (authored by jhb). · Explain WhyFeb 11 2021, 9:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGe07ac3f2fd73: cam: Don't permit crashdumps on non-pollable devices..

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
3 lines
nvme/
3 lines
scsi/
5 lines

Diff 83250

View Options

sys/cam/ata/ata_da.c

Loading...
View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...