Page MenuHomeFreeBSD

net-mgmt/nfs-exporter: new port
ClosedPublic

Authored by asomers on Jan 26 2021, 3:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 2:44 PM
Unknown Object (File)
Sun, Apr 28, 2:42 PM
Unknown Object (File)
Sun, Apr 28, 2:37 PM
Unknown Object (File)
Sun, Apr 28, 2:34 PM
Unknown Object (File)
Sun, Apr 28, 2:09 AM
Unknown Object (File)
Sun, Apr 21, 7:55 PM
Unknown Object (File)
Feb 24 2024, 10:51 AM
Unknown Object (File)
Jan 23 2024, 7:27 PM
Subscribers

Details

Summary

net-mgmt/nfs-exporter: new port

nfs-exporter exports NFS server statistics to Prometheus.

Sponsored by: Axcient

Test Plan

Built for 11.4 and 12.2 in Poudriere. Running in production at Axcient.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36509
Build 33398: arc lint + arc unit

Event Timeline

It looks good to me, but I'm not a porter, so I'll respectfully forward it to the people who are. :)

otis@dev12:/usr/ports2/net-mgmt/nfs-exporter % portclippy Makefile
# PORTNAME block
PORTNAME
DISTVERSION
CATEGORIES
DISTNAME

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_COMB
-LICENSE_FILE_MIT
LICENSE_FILE_APACHE20
+LICENSE_FILE_MIT

# USES block
USES
USE_GITHUB
GH_ACCOUNT
GH_PROJECT
GH_TAGNAME
+USE_RC_SUBR

# USES=cargo related variables
CARGO_CRATES

# Packaging list block
PLIST_FILES

-USE_RC_SUBR
otis@dev12:/usr/ports2/net-mgmt/nfs-exporter % portfmt -D Makefile
--- Makefile
+++ Makefile
@@ -1,125 +1,125 @@
 # $FreeBSD$

 PORTNAME=      nfs-exporter
 DISTVERSION=   0.3.0
 CATEGORIES=    net-mgmt
 DISTNAME=      freebsd-nfs-exporter-${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX}

 MAINTAINER=    asomers@FreeBSD.org
 COMMENT=       Prometheus exporter for NFS statistics

+LICENSE=       APACHE20 MIT
-LICENSE=       MIT APACHE20

Otherwise LGTM.

Formatting changes suggested by @otis

Does it also build and run in 13.0? The release date is approaching.

In D28355#634273, @otis wrote:

Does it also build and run in 13.0? The release date is approaching.

I don't have Poudriere setup for 13.0. But I've tested it by hand on a 13.0-ALPHA1 build from last Friday. It works there.

  • LGTM
  • Adding also my mentors.
In D28355#634284, @otis wrote:
  • LGTM
  • Adding also my mentors.

Hi there Juraj! Long time no see.

This revision is now accepted and ready to land.Jan 26 2021, 5:54 PM
This revision was automatically updated to reflect the committed changes.