Replace all uses of kern_mmap with kern_mmap_req
ClosedPublic
Actions

Authored by brooks on Jan 23 2021, 12:25 AM.

Details

Reviewers

kevans
kib
imp
jhb

Commits

rG7a1591c1b625: Rename kern_mmap_req to kern_mmap

Summary

The helper saved some code churn initially, but having multiple
interfaces is sub-optimal.

Remove the old kern_mmap.

Rename kern_mmap_req to kern_mmap

There is no need for the suffix now that there is only one interface.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Jan 23 2021, 12:25 AM

brooks created this revision.

Harbormaster completed remote builds in B36418: Diff 82747.Jan 23 2021, 12:25 AM

Whitespace fix.

Harbormaster completed remote builds in B36419: Diff 82748.Jan 23 2021, 12:33 AM

I've done this cleanup in CheriBSD on the path to some local cleanups.

I've chosen to use compound literals because they are IMO tidier than single use temporary variables when the initialization values aren't available at the top of the file. They aren't widely used in the tree so now is probably the time to discuss style. The one aspect of the current style I debated the most was if the &(struct foo){ should be on it's own line or on the line above. I felt splitting it out worked well with the other indentation.

kib accepted this revision.Jan 23 2021, 11:43 AM

kib added inline comments.