Page MenuHomeFreeBSD
Differential D28334

Add git-arc
ClosedPublic
Actions

Authored by markj on Jan 25 2021, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 12, 5:25 AM
Unknown Object (File)
Tue, Nov 11, 4:36 AM
Unknown Object (File)
Tue, Nov 11, 3:54 AM
Unknown Object (File)
Tue, Nov 11, 1:18 AM
Unknown Object (File)
Tue, Nov 11, 12:27 AM
Unknown Object (File)
Mon, Nov 10, 9:05 PM
Unknown Object (File)
Mon, Nov 10, 6:01 PM
Unknown Object (File)
Mon, Nov 10, 5:19 PM
View All Files
Subscribers
debdrup
imp
marcnarc_gmail.com

Details

Reviewers
jhb
Commits
rG3279329b2dca: tools/git: Add git-arc
Summary

This is a script to make it easier to manage phabricator reviews for src
commits. It tries to avoid forcing any particular workflow.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36474
Build 33363: arc lint + arc unit

Event Timeline

markj created this revision.Jan 25 2021, 5:24 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 25 2021, 5:24 PM
markj requested review of this revision.Jan 25 2021, 5:24 PM
Harbormaster completed remote builds in B36472: Diff 82858.Jan 25 2021, 5:24 PM
debdrup added a subscriber: debdrup.Jan 25 2021, 7:07 PM

I might also be convinced to write a git-arc(8) man-page. ;)

tools/tools/git/git-arc.sh
51

I would recommend s/verb/command/, as that's the syntax used in other places, for example camcontrol(8), which uses (sub)commands too.

markj marked an inline comment as done.Jan 25 2021, 7:18 PM
In D28334#633784, @debdrup wrote:

I might also be convinced to write a git-arc(8) man-page. ;)

That would be useful. Let's perhaps first wait and see if the interface changes much before I commit.

markj updated this revision to Diff 82862.Jan 25 2021, 7:19 PM
  • Address feedback, verb -> command in the usage message.
Harbormaster completed remote builds in B36474: Diff 82862.Jan 25 2021, 7:19 PM
jhb added inline comments.Jan 25 2021, 8:21 PM
tools/tools/git/git-arc.sh
92

Probably s/upstream/freebsd/ here to match our other git docs.

imp added inline comments.Jan 25 2021, 11:09 PM
tools/tools/git/git-arc.sh
92

Agreed.

markj updated this revision to Diff 82887.Jan 26 2021, 12:09 AM
markj marked an inline comment as done.

Use the canonical name for an upstream FreeBSD remote.

Harbormaster completed remote builds in B36486: Diff 82887.Jan 26 2021, 12:09 AM
marcnarc_gmail.com added a subscriber: marcnarc_gmail.com.Jan 29 2021, 5:36 PM

Is it a show-stopper that this script relies on the textproc/jq port?

markj added a comment.Jan 29 2021, 5:40 PM
In D28334#635691, @marcnarc_gmail.com wrote:

Is it a show-stopper that this script relies on the textproc/jq port?

I don't really expect so since it already relies on the arcanist port. But we should verify that both packages are installed before trying to do anything...

markj updated this revision to Diff 83130.Jan 30 2021, 1:19 AM

Check for jq and arc before trying to do anything.

Harbormaster completed remote builds in B36617: Diff 83130.Jan 30 2021, 1:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 5 2021, 2:48 PM
Closed by commit rG3279329b2dca: tools/git: Add git-arc (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG3279329b2dca: tools/git: Add git-arc.

Revision Contents
Changeset List

PathSize
tools/
tools/
git/
4 lines
588 lines

Diff 82862

View Options

tools/tools/git/Makefile

Loading...
View Options

tools/tools/git/git-arc.sh

Loading...