Differential D27902

virtio_blk: Add modern (V1) support
ClosedPublic
Actions

Authored by bryanv on Jan 2 2021, 8:41 PM.

Details

Reviewers

grehan

Commits

rGd7f979bed092: virtio_blk: Add modern (V1) support

Summary

Rework the header file changes from 2cc8a52 to use our
canonical upstream, Linux.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bryanv created this revision.Jan 2 2021, 8:41 PM

bryanv held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2021, 8:41 PM

Harbormaster completed remote builds in B35867: Diff 81525.Jan 2 2021, 8:41 PM

bryanv published this revision for review.Jan 2 2021, 8:51 PM

bryanv added a reviewer: grehan.

grehan added inline comments.Jan 11 2021, 8:57 AM

sys/dev/virtio/block/virtio_blk.c
580–581	Was the deleted code block a no-op ? (guessing there won't be DELETE bio's if the DISKFLAG_CANDELETE wasn't set)

bryanv marked an inline comment as done.Jan 18 2021, 6:37 PM

bryanv added inline comments.

sys/dev/virtio/block/virtio_blk.c
580–581	Yes. geom_disk already checks for DISKFLAG_CANDELETE before send down the BIO

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:11 AM

Closed by commit rGd7f979bed092: virtio_blk: Add modern (V1) support (authored by bryanv). · Explain Why

This revision was automatically updated to reflect the committed changes.

bryanv marked an inline comment as done.

bryanv added a commit: rGd7f979bed092: virtio_blk: Add modern (V1) support.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

block/

virtio_blk.h

69 lines

virtio_blk.c

121 lines

Diff 82529

View Options

sys/dev/virtio/block/virtio_blk.h