Split out the NODEBUG options to a common file
ClosedPublic
Actions

Authored by andrew on Jan 14 2021, 11:06 AM.

Details

Reviewers

manu
emaste

Commits

rG6eebda3bbad9: Split out the NODEBUG options to a common file

Summary

This is the superset of the nooptions found in the -DEBUG kernels.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36194
Build 33083: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 14 2021, 11:06 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 14 2021, 11:06 AM

Herald added subscribers: jhibbits, emaste, imp. · View Herald Transcript

andrew requested review of this revision.Jan 14 2021, 11:06 AM

Harbormaster completed remote builds in B36194: Diff 82256.Jan 14 2021, 11:06 AM

I've tested on arm64, I still need to run through universe.

andrew changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.Jan 14 2021, 11:08 AM

Not tested but LGTM

This revision is now accepted and ready to land.Jan 14 2021, 11:18 AM

LGTM.

IMO we might want to revisit later and separate these into multiple sets e.g. USB_DEBUG and HID_DEBUG include extra debug that can be enabled at run time and are in a different category from something like WITNESS. For later though, such a change can be more easily investigated/implemented on top of this.

Closed by commit rG6eebda3bbad9: Split out the NODEBUG options to a common file (authored by andrew). · Explain WhyJan 14 2021, 5:04 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG6eebda3bbad9: Split out the NODEBUG options to a common file.

is there an equivalent std.debug file for stable branches?