Paths

Table of Contentst

Differential D27663

rtld-libc: fix incremental build
ClosedPublic
Actions

Authored by rlibby on Dec 17 2020, 11:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 16, 12:07 PM

	Unknown Object (File)
	Wed, Apr 15, 11:51 AM

	Unknown Object (File)
	Wed, Apr 15, 10:11 AM

	Unknown Object (File)
	Wed, Apr 15, 12:06 AM

	Unknown Object (File)
	Tue, Apr 14, 10:07 PM

	Unknown Object (File)
	Tue, Apr 14, 3:57 AM

	Unknown Object (File)
	Thu, Apr 9, 9:05 PM

	Unknown Object (File)
	Sun, Apr 5, 8:04 AM

Subscribers

Details

Reviewers

arichardson
bdrewery
kib

Commits

rS368788: rtld-libc: fix incremental build

Summary

ar cr is an update of an archive, not a creation of a new one. During
incremental builds (e.g. with meta mode) the archive was not getting
cleaned, and so could retain now-deleted objects from previous builds.
Now, delete the archive before creating/updating it.

Test Plan

make buildworld after a failed experiment with rtld-libc and
WITH_META_MODE=YES.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35503
Build 32408: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 17 2020, 11:00 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptDec 17 2020, 11:00 PM

rlibby requested review of this revision.Dec 17 2020, 11:00 PM

Harbormaster completed remote builds in B35502: Diff 80872.Dec 17 2020, 11:00 PM

bdrewery accepted this revision.Dec 18 2020, 12:02 AM

bdrewery added inline comments.

libexec/rtld-elf/rtld-libc/Makefile.inc
98	Normally we do `@rm` to hide the command.

This revision is now accepted and ready to land.Dec 18 2020, 12:02 AM

bdrewery feedback: quiet rm

This revision now requires review to proceed.Dec 18 2020, 1:00 AM

Harbormaster completed remote builds in B35503: Diff 80876.Dec 18 2020, 1:00 AM

kib accepted this revision.Dec 18 2020, 3:10 AM

This revision is now accepted and ready to land.Dec 18 2020, 3:10 AM

arichardson accepted this revision.Dec 18 2020, 5:15 PM

Closed by commit rS368788: rtld-libc: fix incremental build (authored by rlibby). · Explain WhyDec 19 2020, 8:38 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rS368788: rtld-libc: fix incremental build.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld-libc/

3 lines

Diff 80876

libexec/rtld-elf/rtld-libc/Makefile.inc

Loading...