Fix compat32 for ntp_adjtime(2).
ClosedPublic
Actions

Authored by kib on Dec 3 2020, 10:00 PM.

Details

Reviewers

• ian
phk
cy
brooks
emaste

Commits

rS368343: Fix compat32 for ntp_adjtime(2).
rS368342: Add kern_ntp_adjtime(9).

Summary

Add kern_ntp_adjtime(9).
struct timex is not 32-bit safe, it uses longs for members. Provide translation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 35182

Event Timeline

kib created this revision.Dec 3 2020, 10:00 PM

Herald added a reviewer: brooks. · View Herald TranscriptDec 3 2020, 10:00 PM

Herald added a subscriber: imp. · View Herald Transcript

kib requested review of this revision.Dec 3 2020, 10:00 PM

Harbormaster completed remote builds in B35180: Diff 80286.Dec 3 2020, 10:00 PM

kib added a reviewer: emaste.Dec 3 2020, 10:01 PM

I don't see any issues worth noting.

This revision is now accepted and ready to land.Dec 3 2020, 11:12 PM

I'd be tempted to pass timex_copyin and timex_copyout function pointers to kern_ntp_adjtime rather than having duplicate code in sys_ and freebsd32_. That would also simplify a future compat syscall implementation.

sys/kern/kern_ntptime.c
1089–1109	This looks like it's part of a future syscall revision, not the compat change?

In D27471#613779, @brooks wrote:

I'd be tempted to pass timex_copyin and timex_copyout function pointers to kern_ntp_adjtime rather than having duplicate code in sys_ and freebsd32_. That would also simplify a future compat syscall implementation.

Right now it seems there will be no compat syscall, ie struct timex is not going to change.

Do you still want copyin callbacks there ? It is more overhead in code for rather trivial wrappers IMO.

Remove stray chunk.

This revision now requires review to proceed.Dec 3 2020, 11:42 PM

Harbormaster completed remote builds in B35182: Diff 80292.Dec 3 2020, 11:42 PM

Without a compat syscall it seems fine to leave this as is.

brooks accepted this revision.Dec 4 2020, 4:39 PM

This revision is now accepted and ready to land.Dec 4 2020, 4:39 PM

Closed by commit rS368342: Add kern_ntp_adjtime(9). (authored by kib). · Explain WhyDec 4 2020, 6:57 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS368342: Add kern_ntp_adjtime(9)..

kib added a commit: rS368343: Fix compat32 for ntp_adjtime(2)..