Page MenuHomeFreeBSD
Differential D27237

Use getlocalbase() in a few base system programs
ClosedPublic
Actions

Authored by se on Nov 16 2020, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 10:37 AM
Unknown Object (File)
Jan 14 2024, 5:38 AM
Unknown Object (File)
Dec 21 2023, 3:08 PM
Unknown Object (File)
Dec 3 2023, 11:56 AM
Unknown Object (File)
Dec 3 2023, 11:56 AM
Unknown Object (File)
Dec 3 2023, 11:52 AM
Unknown Object (File)
Dec 3 2023, 11:51 AM
Unknown Object (File)
Dec 3 2023, 11:29 AM
View All 32 Files
Subscribers
dab

Details

Reviewers
scottl
imp
bdrewery
bapt
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rS367816: Make use of the getlocalbase() function for run-time adjustment of the
Summary

These are programs that either used getenv("LOCALBASE") or had _PATH_LOCALBASE compiled in and which have been converted to use getlocalbase() instead.

Test Plan

Apply the patches in review D27236 and rebuild and install lib/libutil.

Verify that the programs included in this review can be built and that they continue to run.
Test with different values of the LOCALBASE environment variable and the user.localbase sysctl parameter to verify that the correct path is constructed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 34824

Event Timeline

se created this revision.Nov 16 2020, 11:52 AM
Herald added a reviewer: bdrewery. · View Herald TranscriptNov 16 2020, 11:52 AM
Herald added a subscriber: dab. · View Herald Transcript
se requested review of this revision.Nov 16 2020, 11:52 AM
Harbormaster completed remote builds in B34823: Diff 79597.Nov 16 2020, 11:52 AM
se added a parent revision: D27236: Retrieve LOCALBASE with getlocalbase().Nov 16 2020, 11:53 AM
se retitled this revision from Use getlocalbase() in a few base sysetm programs to Use getlocalbase() in a few base system programs.
se updated this revision to Diff 79598.Nov 16 2020, 12:04 PM

Add another invocation of getlocalbase() instead of getenv("LOCALBASE") in usr.sbin/pkg

Harbormaster completed remote builds in B34824: Diff 79598.Nov 16 2020, 12:04 PM
se mentioned this in D27236: Retrieve LOCALBASE with getlocalbase().Nov 17 2020, 6:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2020, 8:01 PM
Closed by commit rS367816: Make use of the getlocalbase() function for run-time adjustment of the (authored by se). · Explain Why
This revision was automatically updated to reflect the committed changes.
se added a commit: rS367816: Make use of the getlocalbase() function for run-time adjustment of the.
Owners added a reviewer: Restricted Owners Package.Nov 18 2020, 8:01 PM
Herald added a reviewer: bapt. · View Herald TranscriptNov 18 2020, 8:01 PM

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
2 lines
5 lines
usr.sbin/
mailwrapper/
2 lines
pkg/
2 lines
6 lines
5 lines

Diff 79598

View Options

sbin/nvmecontrol/comnd.c

Loading...
View Options

sbin/nvmecontrol/nvmecontrol.c

Loading...
View Options

usr.sbin/mailwrapper/mailwrapper.c

Loading...
View Options

usr.sbin/pkg/Makefile

Loading...
View Options

usr.sbin/pkg/config.c

Loading...
View Options

usr.sbin/pkg/pkg.c

Loading...