Page MenuHomeFreeBSD
Differential D27202

msun tests: use standard floating-point exception flags on lrint and fenv tests
ClosedPublic
Actions

Authored by alfredo on Nov 12 2020, 11:50 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Mar 22, 12:39 AM
Unknown Object (File)
Feb 9 2025, 6:27 PM
Unknown Object (File)
Feb 4 2025, 3:51 AM
Unknown Object (File)
Jan 22 2025, 12:32 AM
Unknown Object (File)
Jan 15 2025, 3:04 PM
Unknown Object (File)
Jan 13 2025, 8:42 PM
Unknown Object (File)
Dec 15 2024, 3:50 AM
Unknown Object (File)
Dec 5 2024, 11:20 PM
View All 81 Files
Subscribers
bdragon
imp
luporl

Details

Reviewers
jhibbits
ngie
bdragon
luporl
Commits
rS367811: msun tests: use standard floating-point exception flags on lrint and fenv tests
Summary

Some platforms have additional architecture-specific floating-point flags. Msun test cases lrint and test_fegsetenv (fenv) expects only standard flags, so make sure to mask them appropriately.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34777
Build 31827: arc lint + arc unit

Event Timeline

alfredo created this revision.Nov 12 2020, 11:50 PM
Herald added subscribers: luporl, bdragon. · View Herald TranscriptNov 12 2020, 11:50 PM
Harbormaster completed remote builds in B34774: Diff 79490.Nov 12 2020, 11:50 PM
alfredo requested review of this revision.Nov 12 2020, 11:50 PM
alfredo updated this revision to Diff 79494.Nov 13 2020, 12:29 AM
alfredo retitled this revision from msun test: use standard floating-point exception flags on test_fegsetenv to msun tests: use standard floating-point exception flags on lrint and fenv tests.
alfredo edited the summary of this revision. (Show Details)
alfredo added reviewers: bdragon, luporl.

lrint has a similar case, so adding to same review

Harbormaster completed remote builds in B34777: Diff 79494.Nov 13 2020, 12:29 AM
jhibbits accepted this revision.Nov 13 2020, 1:06 AM
This revision is now accepted and ready to land.Nov 13 2020, 1:06 AM
ngie accepted this revision.Nov 18 2020, 5:46 AM
ngie added inline comments.
lib/msun/tests/lrint_test.c
49–50

Should this be defined in a more centralized place?

alfredo updated this revision to Diff 79722.Nov 18 2020, 7:15 PM

use ALL_STD_EXCEPT defined by "test-utils.h"

This revision now requires review to proceed.Nov 18 2020, 7:15 PM
Harbormaster completed remote builds in B34890: Diff 79722.Nov 18 2020, 7:15 PM
alfredo marked an inline comment as done.Nov 18 2020, 7:16 PM
alfredo added inline comments.
lib/msun/tests/lrint_test.c
49–50

Just found this is already defined by "test-utils.h", so let's use it and remove the definition from fenv_test.c as well. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2020, 7:23 PM
Closed by commit rS367811: msun tests: use standard floating-point exception flags on lrint and fenv tests (authored by alfredo). · Explain Why
This revision was automatically updated to reflect the committed changes.
alfredo marked an inline comment as done.
alfredo added a commit: rS367811: msun tests: use standard floating-point exception flags on lrint and fenv tests.
Herald added a subscriber: imp. · View Herald TranscriptNov 18 2020, 7:23 PM

Revision Contents
Changeset List

PathSize
lib/
msun/
tests/
8 lines
11 lines

Diff 79494

View Options

lib/msun/tests/fenv_test.c

PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= pyfda
PORTVERSION= 0.1
DISTVERSIONSUFFIX= rc6
CATEGORIES= cad python devel
MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= yuri@FreeBSD.org
COMMENT= GUI tool for designing and analysing discrete time filters
LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE
RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}docutils>0:textproc/py-docutils@${FLAVOR} \
${PYTHON_PKGNAMEPREFIX}matplotlib>0:math/py-matplotlib@${FLAVOR} \
${PYNUMPY} \
${PYTHON_PKGNAMEPREFIX}scipy>0:science/py-scipy@${FLAVOR}
USES= python:3.4+ pyqt:5
USE_PYTHON= distutils autoplist noflavors
matUnsubmitted
Not Done
Inline Actions

Also, setting noflavors (which is weird, no reason to do it) means that the FLAVOR variable is empty, thus, it makes this port broken because the dependencies line end with @ with no flavor.

mat: Also, setting noflavors (which is weird, no reason to do it) means that the FLAVOR variable is…
yuriAuthorUnsubmitted
Not Done
Inline Actions

But this is an app, not a library. Shouldn't python apps all be noflavors?

yuri: But this is an app, not a library. Shouldn't python apps all be `noflavors`?
matUnsubmitted
Not Done
Inline Actions

this has a PKGNAMEPREFIX, nothing against it having noflavors.

mat: this has a PKGNAMEPREFIX, nothing against it having noflavors.
USE_PYQT= core_run gui_run widgets_run
NO_ARCH= yes
post-extract:
@${MV} ${WRKSRC}/pyfda/pyfda_log.conf ${WRKSRC}/pyfda/pyfda_log.conf.sample
@${MV} ${WRKSRC}/pyfda/pyfda_log_debug.conf ${WRKSRC}/pyfda/pyfda_log_debug.conf.sample
post-patch:
@${REINPLACE_CMD} -e " \
s|package_data={'pyfda': \['pyfda_log.conf', 'pyfda_log_debug.conf',|package_data={'pyfda': [|; \
s|data_files = \[|data_files = [('${PREFIX}/etc', ['pyfda/pyfda_log.conf.sample', 'pyfda/pyfda_log_debug.conf.sample'])|" \
${WRKSRC}/setup.py
@${REINPLACE_CMD} -e " \
s|logging.config.fileConfig(os.path.join(base_dir, rc.log_config_file))|logging.config.fileConfig(os.path.join('${PREFIX}/etc', rc.log_config_file))|" \
${WRKSRC}/pyfda/pyfdax.py
@${REINPLACE_CMD} -e " \
s|'pyfda.log'|'/tmp/pyfda.log'|" \
${WRKSRC}/pyfda/*.conf.sample
post-stage:
@${REINPLACE_CMD} -E " \
s|(.*\.sample)$$|@sample \1|" \
${WRKDIR}/.PLIST.pymodtmp
.include <bsd.port.mk>
View Options

lib/msun/tests/lrint_test.c

PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= pyfda
PORTVERSION= 0.1
DISTVERSIONSUFFIX= rc6
CATEGORIES= cad python devel
MASTER_SITES= CHEESESHOP
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= yuri@FreeBSD.org
COMMENT= GUI tool for designing and analysing discrete time filters
LICENSE= MIT
LICENSE_FILE= ${WRKSRC}/LICENSE
RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}docutils>0:textproc/py-docutils@${FLAVOR} \
${PYTHON_PKGNAMEPREFIX}matplotlib>0:math/py-matplotlib@${FLAVOR} \
${PYNUMPY} \
${PYTHON_PKGNAMEPREFIX}scipy>0:science/py-scipy@${FLAVOR}
USES= python:3.4+ pyqt:5
USE_PYTHON= distutils autoplist noflavors
matUnsubmitted
Not Done
Inline Actions

Also, setting noflavors (which is weird, no reason to do it) means that the FLAVOR variable is empty, thus, it makes this port broken because the dependencies line end with @ with no flavor.

mat: Also, setting noflavors (which is weird, no reason to do it) means that the FLAVOR variable is…
yuriAuthorUnsubmitted
Not Done
Inline Actions

But this is an app, not a library. Shouldn't python apps all be noflavors?

yuri: But this is an app, not a library. Shouldn't python apps all be `noflavors`?
matUnsubmitted
Not Done
Inline Actions

this has a PKGNAMEPREFIX, nothing against it having noflavors.

mat: this has a PKGNAMEPREFIX, nothing against it having noflavors.
USE_PYQT= core_run gui_run widgets_run
NO_ARCH= yes
post-extract:
@${MV} ${WRKSRC}/pyfda/pyfda_log.conf ${WRKSRC}/pyfda/pyfda_log.conf.sample
@${MV} ${WRKSRC}/pyfda/pyfda_log_debug.conf ${WRKSRC}/pyfda/pyfda_log_debug.conf.sample
post-patch:
@${REINPLACE_CMD} -e " \
s|package_data={'pyfda': \['pyfda_log.conf', 'pyfda_log_debug.conf',|package_data={'pyfda': [|; \
s|data_files = \[|data_files = [('${PREFIX}/etc', ['pyfda/pyfda_log.conf.sample', 'pyfda/pyfda_log_debug.conf.sample'])|" \
${WRKSRC}/setup.py
@${REINPLACE_CMD} -e " \
s|logging.config.fileConfig(os.path.join(base_dir, rc.log_config_file))|logging.config.fileConfig(os.path.join('${PREFIX}/etc', rc.log_config_file))|" \
${WRKSRC}/pyfda/pyfdax.py
@${REINPLACE_CMD} -e " \
s|'pyfda.log'|'/tmp/pyfda.log'|" \
${WRKSRC}/pyfda/*.conf.sample
post-stage:
@${REINPLACE_CMD} -E " \
s|(.*\.sample)$$|@sample \1|" \
${WRKDIR}/.PLIST.pymodtmp
.include <bsd.port.mk>