msun tests: use standard floating-point exception flags on lrint and fenv tests
ClosedPublic
Actions

Authored by alfredo on Nov 12 2020, 11:50 PM.

Details

Reviewers

jhibbits
ngie
bdragon
luporl

Commits

rS367811: msun tests: use standard floating-point exception flags on lrint and fenv tests

Summary

Some platforms have additional architecture-specific floating-point flags. Msun test cases lrint and test_fegsetenv (fenv) expects only standard flags, so make sure to mask them appropriately.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34890
Build 31911: arc lint + arc unit

Event Timeline

alfredo created this revision.Nov 12 2020, 11:50 PM

Herald added subscribers: luporl, bdragon. · View Herald TranscriptNov 12 2020, 11:50 PM

Harbormaster completed remote builds in B34774: Diff 79490.Nov 12 2020, 11:50 PM

alfredo requested review of this revision.Nov 12 2020, 11:50 PM

lrint has a similar case, so adding to same review

Harbormaster completed remote builds in B34777: Diff 79494.Nov 13 2020, 12:29 AM

jhibbits accepted this revision.Nov 13 2020, 1:06 AM

This revision is now accepted and ready to land.Nov 13 2020, 1:06 AM

ngie accepted this revision.Nov 18 2020, 5:46 AM

ngie added inline comments.

lib/msun/tests/lrint_test.c
49–50	Should this be defined in a more centralized place?

use ALL_STD_EXCEPT defined by "test-utils.h"

This revision now requires review to proceed.Nov 18 2020, 7:15 PM

Harbormaster completed remote builds in B34890: Diff 79722.Nov 18 2020, 7:15 PM

alfredo marked an inline comment as done.Nov 18 2020, 7:16 PM

alfredo added inline comments.

lib/msun/tests/lrint_test.c
49–50	Just found this is already defined by "test-utils.h", so let's use it and remove the definition from fenv_test.c as well. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2020, 7:23 PM

Closed by commit rS367811: msun tests: use standard floating-point exception flags on lrint and fenv tests (authored by alfredo). · Explain Why

This revision was automatically updated to reflect the committed changes.

alfredo marked an inline comment as done.

alfredo added a commit: rS367811: msun tests: use standard floating-point exception flags on lrint and fenv tests.

Herald added a subscriber: imp. · View Herald TranscriptNov 18 2020, 7:23 PM

Revision Contents
Changeset List

Path

Size

lib/

msun/

tests/

fenv_test.c

16 lines

lrint_test.c

5 lines

Diff 79722

View Options

lib/msun/tests/fenv_test.c