Page MenuHomeFreeBSD
Differential D27134

makeman: Don't require filemon with MK_DIRDEPS_BUILD.
ClosedPublic
Actions

Authored by bdrewery on Nov 7 2020, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 26, 7:19 AM
Unknown Object (File)
Wed, Mar 25, 6:29 AM
Unknown Object (File)
Wed, Mar 25, 3:57 AM
Unknown Object (File)
Tue, Mar 24, 3:26 AM
Unknown Object (File)
Tue, Mar 24, 3:26 AM
Unknown Object (File)
Tue, Mar 17, 5:38 AM
Unknown Object (File)
Tue, Mar 17, 3:55 AM
Unknown Object (File)
Sun, Mar 15, 9:03 AM
View All Files
Subscribers
dim
emaste
imp

Details

Reviewers
sjg
kevans
dim
Commits
rS367570: makeman: Don't require filemon with MK_DIRDEPS_BUILD.
Summary

makeman uses make showconfig at the top-level while iterating over
every option combination. When it runs make showconfig MK_DIRDEPS_BUILD=yes
it encounters the requirement for filemon to be loaded. We don't need
filemon here as it is only displaying all MK_ values.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34716
Build 31774: arc lint + arc unit

Event Timeline

bdrewery created this revision.Nov 7 2020, 5:15 PM
Herald added a subscriber: emaste. · View Herald TranscriptNov 7 2020, 5:15 PM
bdrewery requested review of this revision.Nov 7 2020, 5:15 PM
Harbormaster completed remote builds in B34683: Diff 79302.Nov 7 2020, 5:15 PM
dim accepted this revision.Nov 7 2020, 5:31 PM

I've been using this for a while already, since otherwise makeman fails for me. :)

This revision is now accepted and ready to land.Nov 7 2020, 5:31 PM
sjg added inline comments.Nov 8 2020, 2:27 AM
share/mk/meta.sys.mk
142 ↗(On Diff #79302)

This would be better done via local.meta.sys.mk eg

.if make(showconfig)
UPDATE_DEPENDFILE= no
.endif

then meta.sys.mk could be kept in sync with bmake distrib

bdrewery updated this revision to Diff 79360.Nov 9 2020, 8:21 PM

Move to local.meta.sys.mk

This revision now requires review to proceed.Nov 9 2020, 8:21 PM
Harbormaster completed remote builds in B34715: Diff 79360.Nov 9 2020, 8:21 PM
bdrewery updated this revision to Diff 79361.Nov 9 2020, 8:22 PM

Add comment

Harbormaster completed remote builds in B34716: Diff 79361.Nov 9 2020, 8:22 PM
sjg accepted this revision.Nov 10 2020, 4:43 AM
This revision is now accepted and ready to land.Nov 10 2020, 4:43 AM
Closed by commit rS367570: makeman: Don't require filemon with MK_DIRDEPS_BUILD. (authored by bdrewery). · Explain WhyNov 10 2020, 6:05 PM
This revision was automatically updated to reflect the committed changes.
bdrewery added a commit: rS367570: makeman: Don't require filemon with MK_DIRDEPS_BUILD..
Herald added a subscriber: imp. · View Herald TranscriptNov 10 2020, 6:05 PM

Revision Contents
Changeset List

PathSize
share/
mk/
4 lines

Diff 79361

View Options

share/mk/local.meta.sys.mk

Loading...