makeman: Don't require filemon with MK_DIRDEPS_BUILD.
ClosedPublic
Actions

Authored by bdrewery on Nov 7 2020, 5:15 PM.

Details

Reviewers

sjg
kevans
dim

Commits

rS367570: makeman: Don't require filemon with MK_DIRDEPS_BUILD.

Summary

makeman uses make showconfig at the top-level while iterating over
every option combination. When it runs make showconfig MK_DIRDEPS_BUILD=yes
it encounters the requirement for filemon to be loaded. We don't need
filemon here as it is only displaying all MK_ values.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34715
Build 31773: arc lint + arc unit

Event Timeline

bdrewery created this revision.Nov 7 2020, 5:15 PM

Herald added a subscriber: emaste. · View Herald TranscriptNov 7 2020, 5:15 PM

bdrewery requested review of this revision.Nov 7 2020, 5:15 PM

Harbormaster completed remote builds in B34683: Diff 79302.Nov 7 2020, 5:15 PM

I've been using this for a while already, since otherwise makeman fails for me. :)

This revision is now accepted and ready to land.Nov 7 2020, 5:31 PM

sjg added inline comments.Nov 8 2020, 2:27 AM

share/mk/meta.sys.mk
142 ↗	(On Diff #79302)	This would be better done via local.meta.sys.mk eg .if make(showconfig) UPDATE_DEPENDFILE= no .endif then meta.sys.mk could be kept in sync with bmake distrib