Page MenuHomeFreeBSD

Fix bad libbxo format strings in jls
ClosedPublic

Authored by arichardson on Oct 21 2020, 11:18 AM.
Tags
None
Referenced Files
F149205423: D26885.id79171.diff
Mon, Mar 23, 12:05 AM
Unknown Object (File)
Sat, Mar 21, 6:35 AM
Unknown Object (File)
Tue, Mar 17, 5:24 PM
Unknown Object (File)
Sun, Mar 15, 6:45 AM
Unknown Object (File)
Sun, Mar 8, 9:28 PM
Unknown Object (File)
Sun, Mar 8, 9:07 PM
Unknown Object (File)
Sat, Mar 7, 12:15 PM
Unknown Object (File)
Tue, Mar 3, 6:26 PM
Subscribers

Details

Summary

The existing format string for the empty case was trying to read varargs
values that weren't passed to xo_emit. This appears to work on x86 (since
the next argument is probably a pointer an empty string), but for CHERI
we can bound variadic arguments and detect a read past the end.

While touching these lines also use the libxo a modifier to avoid having to
construct the libxo format string using asprintf.

Found by: CHERI

Test Plan

crashes on CHERI-MIPS before, now prints the expected values (XML and Text)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable