Page MenuHomeFreeBSD
Differential D26528

Optimize riscv's cpu_fetch_syscall_args()
ClosedPublic
Actions

Authored by trasz on Sep 23 2020, 11:31 AM.
Tags
None
Referenced Files
F169310091: D26528.id77412.diff
Tue, Sep 1, 4:24 AM
F169299064: D26528.id77728.diff
Tue, Sep 1, 3:53 AM
F169292601: D26528.id77812.diff
Tue, Sep 1, 3:39 AM
F169162250: D26528.id.diff
Mon, Aug 31, 3:35 PM
Unknown Object (File)
Mon, Aug 31, 3:04 AM
Unknown Object (File)
Sun, Aug 30, 8:36 AM
Unknown Object (File)
Sat, Aug 29, 1:15 AM
Unknown Object (File)
Thu, Aug 27, 1:54 PM
View All Files
Subscribers
arichardson
imp
jrtc27
mhorne

Details

Reviewers
arichardson
mhorne
Group Reviewers
riscv
Commits
rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible
Summary

Optimize riscv's cpu_fetch_syscall_args(), making it possible
for the compiler to inline the memcpy.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Sep 23 2020, 11:31 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 23 2020, 11:31 AM
trasz requested review of this revision.Sep 23 2020, 11:31 AM
Harbormaster completed remote builds in B33758: Diff 77412.Sep 23 2020, 11:31 AM
trasz updated this revision to Diff 77477.Sep 24 2020, 9:37 AM

Fix tinderbox.

Harbormaster completed remote builds in B33794: Diff 77477.Sep 24 2020, 9:37 AM
trasz updated this revision to Diff 77728.Oct 1 2020, 3:36 PM

Better version.

Harbormaster completed remote builds in B33927: Diff 77728.Oct 1 2020, 3:36 PM
trasz added a reviewer: riscv.Oct 1 2020, 3:36 PM
arichardson accepted this revision as: arichardson.Oct 1 2020, 3:42 PM
arichardson added a subscriber: arichardson.

If anyone is interested, here is some compiler output to show that the latest version avoids a branch compared to the first one: https://cheri-compiler-explorer.cl.cam.ac.uk/z/T4fdEa

This revision is now accepted and ready to land.Oct 1 2020, 3:42 PM
mhorne added a subscriber: mhorne.Oct 1 2020, 3:52 PM
mhorne added inline comments.
sys/riscv/riscv/trap.c
101 ↗(On Diff #77728)

No longer needed.

124 ↗(On Diff #77728)

Should be dst_ap ?

trasz marked 2 inline comments as done.Oct 1 2020, 6:50 PM
trasz added inline comments.
sys/riscv/riscv/trap.c
124 ↗(On Diff #77728)

Sigh, you're right. It's been manually cherry-picked from another tree.

trasz updated this revision to Diff 77747.Oct 1 2020, 6:50 PM
trasz marked an inline comment as done.

Make it actually build.

This revision now requires review to proceed.Oct 1 2020, 6:50 PM
Harbormaster completed remote builds in B33934: Diff 77747.Oct 1 2020, 6:50 PM
mhorne accepted this revision.Oct 1 2020, 7:04 PM

Looks good. Presumably this passed basic testing in CheriBSD?

This revision is now accepted and ready to land.Oct 1 2020, 7:04 PM
jrtc27 added a subscriber: jrtc27.Oct 1 2020, 8:11 PM

Yes, it passed our basic CI testing (boot to multiuser, SSH in, run our own cheri(abi)test unit test programs and run the cat kyua tests).

NB: arm and arm64 are the same as riscv currently is, so if we're changing riscv we should really make the same change to those two ports too.

Closed by commit rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible (authored by trasz). · Explain WhyOct 3 2020, 1:01 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible.

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
19 lines

Diff 77812

View Options

head/sys/riscv/riscv/trap.c

Loading...