Page MenuHomeFreeBSD

Optimize riscv's cpu_fetch_syscall_args()
ClosedPublic

Authored by trasz on Sep 23 2020, 11:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 10:27 PM
Unknown Object (File)
Jan 27 2024, 1:57 PM
Unknown Object (File)
Jan 2 2024, 8:09 PM
Unknown Object (File)
Dec 30 2023, 7:53 PM
Unknown Object (File)
Dec 28 2023, 10:49 PM
Unknown Object (File)
Dec 20 2023, 5:46 AM
Unknown Object (File)
Dec 8 2023, 6:47 AM
Unknown Object (File)
Oct 12 2023, 7:15 AM

Details

Summary

Optimize riscv's cpu_fetch_syscall_args(), making it possible
for the compiler to inline the memcpy.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33794
Build 31011: arc lint + arc unit

Event Timeline

arichardson added a subscriber: arichardson.

If anyone is interested, here is some compiler output to show that the latest version avoids a branch compared to the first one: https://cheri-compiler-explorer.cl.cam.ac.uk/z/T4fdEa

This revision is now accepted and ready to land.Oct 1 2020, 3:42 PM
mhorne added inline comments.
sys/riscv/riscv/trap.c
101

No longer needed.

125

Should be dst_ap ?

trasz marked 2 inline comments as done.Oct 1 2020, 6:50 PM
trasz added inline comments.
sys/riscv/riscv/trap.c
125

Sigh, you're right. It's been manually cherry-picked from another tree.

trasz marked an inline comment as done.

Make it actually build.

This revision now requires review to proceed.Oct 1 2020, 6:50 PM

Looks good. Presumably this passed basic testing in CheriBSD?

This revision is now accepted and ready to land.Oct 1 2020, 7:04 PM

Yes, it passed our basic CI testing (boot to multiuser, SSH in, run our own cheri(abi)test unit test programs and run the cat kyua tests).

NB: arm and arm64 are the same as riscv currently is, so if we're changing riscv we should really make the same change to those two ports too.