Paths

Table of Contentst

Differential D26528

Optimize riscv's cpu_fetch_syscall_args()
ClosedPublic
Actions

Authored by trasz on Sep 23 2020, 11:31 AM.

Tags

None

Referenced Files

	F163416301: D26528.id77812.diff
	Thu, Jul 23, 12:50 AM

	F163398530: D26528.id.diff
	Wed, Jul 22, 8:49 PM

	Unknown Object (File)
	Wed, Jul 22, 2:00 PM

	Unknown Object (File)
	Wed, Jul 22, 12:50 PM

	Unknown Object (File)
	Mon, Jul 20, 12:19 AM

	Unknown Object (File)
	Sun, Jul 19, 5:21 PM

	Unknown Object (File)
	Tue, Jul 14, 9:38 PM

	Unknown Object (File)
	Tue, Jul 7, 9:44 AM

Subscribers

Details

Reviewers

arichardson
mhorne

Group Reviewers

Commits

rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible

Summary

Optimize riscv's cpu_fetch_syscall_args(), making it possible
for the compiler to inline the memcpy.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33794
Build 31011: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 23 2020, 11:31 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 23 2020, 11:31 AM

trasz requested review of this revision.Sep 23 2020, 11:31 AM

Harbormaster completed remote builds in B33758: Diff 77412.Sep 23 2020, 11:31 AM

Fix tinderbox.

Harbormaster completed remote builds in B33794: Diff 77477.Sep 24 2020, 9:37 AM

Better version.

Harbormaster completed remote builds in B33927: Diff 77728.Oct 1 2020, 3:36 PM

trasz added a reviewer: riscv.Oct 1 2020, 3:36 PM

If anyone is interested, here is some compiler output to show that the latest version avoids a branch compared to the first one: https://cheri-compiler-explorer.cl.cam.ac.uk/z/T4fdEa

This revision is now accepted and ready to land.Oct 1 2020, 3:42 PM

mhorne added a subscriber: mhorne.Oct 1 2020, 3:52 PM

mhorne added inline comments.

sys/riscv/riscv/trap.c
101	No longer needed.
125	Should be `dst_ap` ?

trasz marked 2 inline comments as done.Oct 1 2020, 6:50 PM

trasz added inline comments.

sys/riscv/riscv/trap.c
125	Sigh, you're right. It's been manually cherry-picked from another tree.

Make it actually build.

This revision now requires review to proceed.Oct 1 2020, 6:50 PM

Harbormaster completed remote builds in B33934: Diff 77747.Oct 1 2020, 6:50 PM

Looks good. Presumably this passed basic testing in CheriBSD?

This revision is now accepted and ready to land.Oct 1 2020, 7:04 PM

Yes, it passed our basic CI testing (boot to multiuser, SSH in, run our own cheri(abi)test unit test programs and run the cat kyua tests).

NB: arm and arm64 are the same as riscv currently is, so if we're changing riscv we should really make the same change to those two ports too.

Closed by commit rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible (authored by trasz). · Explain WhyOct 3 2020, 1:01 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible.

Revision Contents
Changeset List

Path

Size

sys/

riscv/

riscv/

20 lines

Diff 77477

sys/riscv/riscv/trap.c

Loading...