= 12.
ClosedPublic
Actions

Authored by brooks on Sep 29 2020, 8:14 PM.

Details

Reviewers

arichardson
emaste
dim

Commits

rS366273: Hoist comment on fixup of ld path
rS366270: Prefer --ld-path=/path/to/ld on clang >= 12

Summary

Clang 12 warns about passing a path to -fuse-ld and -Werror makes that
an error preventing building world.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33882
Build 31090: arc lint + arc unit

Event Timeline

brooks created this revision.Sep 29 2020, 8:14 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptSep 29 2020, 8:14 PM

brooks requested review of this revision.Sep 29 2020, 8:14 PM

Harbormaster completed remote builds in B33882: Diff 77646.Sep 29 2020, 8:14 PM

arichardson accepted this revision.Sep 29 2020, 9:58 PM

This revision is now accepted and ready to land.Sep 29 2020, 9:58 PM

I saw the change to add --ld-path being committed to llvm but missed the new warning. Should have probably made this change as part of the fuse-ld commit...

emaste accepted this revision.Sep 29 2020, 10:13 PM

Closed by commit rS366270: Prefer --ld-path=/path/to/ld on clang >= 12 (authored by brooks). · Explain WhySep 29 2020, 10:30 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS366270: Prefer --ld-path=/path/to/ld on clang >= 12.

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2020, 10:30 PM

jrtc27 added a subscriber: jrtc27.Sep 29 2020, 11:18 PM

jrtc27 added inline comments.

head/share/mk/bsd.sys.mk
303 ↗	(On Diff #77662)	This comment still applies for --ld-path, albeit with s/-fuse-ld/--ld-path/.

brooks added a commit: rS366273: Hoist comment on fixup of ld path.Sep 29 2020, 11:48 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.sys.mk

5 lines

Diff 77646

View Options

Prefer --ld-path=/path/to/ld on clang >= 12.ClosedPublicActions