jbeich reported that xargs -Px doesn't work anymore because
of a botched rebase. This is true, but easy to fix. See attached patch.
I also added test cases to xargs to test -P functionality in the future.
There is Bugzilla 202152 about this.
Details
Details
kyua -k /usr/tests usr.bin/xargs
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 11 Build 11: arc lint + arc unit
Event Timeline
Comment Actions
- Code looks OK but see inline nit.
- Tests look OK for rS286289 scope as it didn't touch how processes are spawned.
Note, I'm not a src/ committer to have much weight.
| usr.bin/xargs/xargs.c | ||
|---|---|---|
| 173–174 | Unreachable as errstr conditional above already checks valid range: $ printf 'a\nb\nc\n' | xargs -P -1 echo xargs: -P -1: too small | |
Comment Actions
In the process of being switched from strtoul() to strtonum(), a check against endptr was not removed, causing xargs to segfault
This patch fixes that, and adds a set of regression tests against the -P flag, that were previously missing.
I would like to commit this, to fix the previous commit.