Optimize riscv's cpu_fetch_syscall_args(), making it possible
for the compiler to inline the memcpy.
Details
Details
- Reviewers
arichardson mhorne - Group Reviewers
riscv - Commits
- rS366392: Optimize riscv's cpu_fetch_syscall_args(), making it possible
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33794 Build 31011: arc lint + arc unit
Event Timeline
Comment Actions
If anyone is interested, here is some compiler output to show that the latest version avoids a branch compared to the first one: https://cheri-compiler-explorer.cl.cam.ac.uk/z/T4fdEa
sys/riscv/riscv/trap.c | ||
---|---|---|
125 | Sigh, you're right. It's been manually cherry-picked from another tree. |
Comment Actions
Yes, it passed our basic CI testing (boot to multiuser, SSH in, run our own cheri(abi)test unit test programs and run the cat kyua tests).
NB: arm and arm64 are the same as riscv currently is, so if we're changing riscv we should really make the same change to those two ports too.