Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
F175044685: D26500.id77268.diff
Wed, Oct 7, 8:56 PM
F175037354: D26500.id77269.diff
Wed, Oct 7, 7:46 PM
F174964722: D26500.diff
Wed, Oct 7, 6:10 AM
Unknown Object (File)
Sat, Oct 3, 6:53 PM
Unknown Object (File)
Fri, Sep 25, 12:28 AM
Unknown Object (File)
Fri, Sep 25, 12:03 AM
Unknown Object (File)
Thu, Sep 24, 11:51 PM
Unknown Object (File)
Fri, Sep 11, 2:18 PM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable