Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
F82827783: D26500.id77268.diff
Thu, May 2, 10:45 PM
Unknown Object (File)
Sat, Apr 27, 2:59 AM
Unknown Object (File)
Sat, Apr 27, 2:59 AM
Unknown Object (File)
Sat, Apr 27, 1:20 AM
Unknown Object (File)
Fri, Apr 19, 9:12 PM
Unknown Object (File)
Dec 23 2023, 10:53 AM
Unknown Object (File)
Dec 20 2023, 12:00 AM
Unknown Object (File)
Dec 5 2023, 4:55 PM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable