Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
F171138880: D26500.diff
Tue, Sep 8, 11:03 PM
Unknown Object (File)
Tue, Sep 8, 9:13 AM
Unknown Object (File)
Sun, Sep 6, 2:10 PM
Unknown Object (File)
Sun, Sep 6, 5:49 AM
Unknown Object (File)
Sun, Sep 6, 1:02 AM
Unknown Object (File)
Sun, Sep 6, 12:07 AM
Unknown Object (File)
Sat, Sep 5, 3:32 PM
Unknown Object (File)
Sat, Sep 5, 7:25 AM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33678
Build 30916: arc lint + arc unit