Page MenuHomeFreeBSD
Differential D26414

Extend netstat to display the TCP congestion control
ClosedPublic
Actions

Authored by tuexen on Sep 12 2020, 2:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 7:17 AM
Unknown Object (File)
Sat, Apr 27, 5:03 PM
Unknown Object (File)
Sat, Apr 27, 5:03 PM
Unknown Object (File)
Sat, Apr 27, 5:03 PM
Unknown Object (File)
Sat, Apr 27, 5:03 PM
Unknown Object (File)
Sat, Apr 27, 3:55 PM
Unknown Object (File)
Sat, Apr 27, 3:24 PM
Unknown Object (File)
Feb 15 2024, 4:33 AM
View All 29 Files
Subscribers
imp
jilles

Details

Reviewers
rscheff
rrs
Group Reviewers
manpages
Commits
rS365688: Add a -C option to netstat to display the congestion control for
Summary

This patch adds the -c option to netstat, which enables the displaying of the name of the congestion control module used by a TCP connection.

This depends on D26412.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 12 2020, 2:43 PM
Herald added a reviewer: manpages. · View Herald TranscriptSep 12 2020, 2:43 PM
Herald added a subscriber: imp. · View Herald Transcript
tuexen requested review of this revision.Sep 12 2020, 2:43 PM
Harbormaster completed remote builds in B33523: Diff 76947.Sep 12 2020, 2:43 PM
jilles added a subscriber: jilles.Sep 12 2020, 5:35 PM

Perhaps it is better to match sockstat (D26413) and make the option -C instead of -c.

tuexen updated this revision to Diff 76953.Sep 12 2020, 6:03 PM

Use -C instead of -c.

Harbormaster completed remote builds in B33526: Diff 76953.Sep 12 2020, 6:03 PM
tuexen added a comment.Sep 12 2020, 6:04 PM
In D26414#587458, @jilles wrote:

Perhaps it is better to match sockstat (D26413) and make the option -C instead of -c.

Done, but the options are already not in sync:

  • -p in netstat and -P in sockstat for selecting the protocol.
  • -a in netstat and -l in sockstat for showing listening sockets.
rscheff accepted this revision.Sep 12 2020, 9:25 PM

I wanted to suggest using -C (for reasons, instead of -c), but seeing this is already addressed...

This revision is now accepted and ready to land.Sep 12 2020, 9:25 PM
Closed by commit rS365688: Add a -C option to netstat to display the congestion control for (authored by tuexen). · Explain WhySep 13 2020, 9:14 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS365688: Add a -C option to netstat to display the congestion control for.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
netstat/
15 lines
6 lines
1 line
8 lines

Diff 76972

View Options

head/usr.bin/netstat/inet.c

Loading...
View Options

head/usr.bin/netstat/main.c

Loading...
View Options

head/usr.bin/netstat/netstat.h

Loading...
View Options

head/usr.bin/netstat/netstat.1

Loading...