Page MenuHomeFreeBSD
Differential D26412

Export TCP congestion control name
ClosedPublic
Actions

Authored by tuexen on Sep 12 2020, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 14, 4:39 AM
Unknown Object (File)
Sun, Jul 6, 7:17 PM
Unknown Object (File)
Sat, Jul 5, 10:54 PM
Unknown Object (File)
Sat, Jul 5, 7:56 AM
Unknown Object (File)
Sat, Jul 5, 7:14 AM
Unknown Object (File)
Fri, Jul 4, 12:48 AM
Unknown Object (File)
Thu, Jul 3, 9:50 AM
Unknown Object (File)
Tue, Jul 1, 12:07 PM
View All 96 Files
Subscribers
imp
melifaro

Details

Reviewers
rscheff
rrs
Group Reviewers
transport
Commits
rS365686: Export the name of the congestion control. This will be used by sockstat
Summary

Export the TCP congestion control name to userland. A separate commit will extend sockstat to display it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 12 2020, 2:03 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 12 2020, 2:03 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Sep 12 2020, 2:03 PM
Harbormaster completed remote builds in B33521: Diff 76945.Sep 12 2020, 2:03 PM
rscheff requested changes to this revision.Sep 12 2020, 9:14 PM
rscheff added inline comments.
sys/netinet/tcp_var.h
770 ↗(On Diff #76945)

I suggest to move this string (of limited size) next to the other strings atop the struct.

This revision now requires changes to proceed.Sep 12 2020, 9:14 PM
tuexen updated this revision to Diff 76960.Sep 12 2020, 10:12 PM

Move CC name up as suggested by Richard.

Harbormaster completed remote builds in B33533: Diff 76960.Sep 12 2020, 10:12 PM
tuexen added inline comments.Sep 12 2020, 10:12 PM
sys/netinet/tcp_var.h
770 ↗(On Diff #76945)

Done.

rscheff accepted this revision.Sep 12 2020, 10:25 PM
This revision is now accepted and ready to land.Sep 12 2020, 10:25 PM
Closed by commit rS365686: Export the name of the congestion control. This will be used by sockstat (authored by tuexen). · Explain WhySep 13 2020, 9:07 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS365686: Export the name of the congestion control. This will be used by sockstat.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
2 lines
3 lines

Diff 76970

View Options

head/sys/netinet/tcp_subr.c

Show All 22 Lines
USES= gmake lua:51,run mono openal:soft USES= gmake lua:51,run mono openal:soft
USE_SDL= sdl2 USE_SDL= sdl2
INSTALLS_ICONS= yes INSTALLS_ICONS= yes
MAKE_ENV= prefix="${PREFIX}" MAKE_ENV= prefix="${PREFIX}"
MAKE_ARGS= VERSION="${GH_TAGNAME}" MAKE_ARGS= VERSION="${GH_TAGNAME}"
INSTALL_TARGET= install-all install-linux-shortcuts INSTALL_TARGET= install-all install-linux-shortcuts
DATADIR= ${PREFIX}/lib/${PORTNAME} DATADIR= ${PREFIX}/lib/${PORTNAME}
PORTDATA= * PORTDATA= *
PORTDOCS= * PORTDOCS= *.html
OPTIONS_DEFINE= DOCS TEST ZENITY OPTIONS_DEFINE= DOCS TEST ZENITY
OPTIONS_DEFAULT=ZENITY OPTIONS_DEFAULT=ZENITY
DOCS_BUILD_DEPENDS=markdown:${PORTSDIR}/textproc/markdown DOCS_BUILD_DEPENDS=markdown:${PORTSDIR}/textproc/markdown
DOCS_ALL_TARGET=docs DOCS_ALL_TARGET=docs
TEST_MAKE_ENV= HOME="${WRKDIR}" TEST_MAKE_ENV= HOME="${WRKDIR}"
Show All 27 Lines.if ${PORT_OPTIONS:MDOCS}
@for f in ${WRKSRC}/*.md; do \ @for f in ${WRKSRC}/*.md; do \
markdown $$f >$${f%.md}.html; \ markdown $$f >$${f%.md}.html; \
done done
.endif .endif
post-install: post-install:
.if ${PORT_OPTIONS:MDOCS} .if ${PORT_OPTIONS:MDOCS}
@${MKDIR} ${STAGEDIR}${DOCSDIR} @${MKDIR} ${STAGEDIR}${DOCSDIR}
${INSTALL_MAN} ${WRKSRC}/*.html ${STAGEDIR}${DOCSDIR} ${INSTALL_MAN} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.endif .endif
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

head/sys/netinet/tcp_var.h

Show All 22 Lines
USES= gmake lua:51,run mono openal:soft USES= gmake lua:51,run mono openal:soft
USE_SDL= sdl2 USE_SDL= sdl2
INSTALLS_ICONS= yes INSTALLS_ICONS= yes
MAKE_ENV= prefix="${PREFIX}" MAKE_ENV= prefix="${PREFIX}"
MAKE_ARGS= VERSION="${GH_TAGNAME}" MAKE_ARGS= VERSION="${GH_TAGNAME}"
INSTALL_TARGET= install-all install-linux-shortcuts INSTALL_TARGET= install-all install-linux-shortcuts
DATADIR= ${PREFIX}/lib/${PORTNAME} DATADIR= ${PREFIX}/lib/${PORTNAME}
PORTDATA= * PORTDATA= *
PORTDOCS= * PORTDOCS= *.html
OPTIONS_DEFINE= DOCS TEST ZENITY OPTIONS_DEFINE= DOCS TEST ZENITY
OPTIONS_DEFAULT=ZENITY OPTIONS_DEFAULT=ZENITY
DOCS_BUILD_DEPENDS=markdown:${PORTSDIR}/textproc/markdown DOCS_BUILD_DEPENDS=markdown:${PORTSDIR}/textproc/markdown
DOCS_ALL_TARGET=docs DOCS_ALL_TARGET=docs
TEST_MAKE_ENV= HOME="${WRKDIR}" TEST_MAKE_ENV= HOME="${WRKDIR}"
Show All 27 Lines.if ${PORT_OPTIONS:MDOCS}
@for f in ${WRKSRC}/*.md; do \ @for f in ${WRKSRC}/*.md; do \
markdown $$f >$${f%.md}.html; \ markdown $$f >$${f%.md}.html; \
done done
.endif .endif
post-install: post-install:
.if ${PORT_OPTIONS:MDOCS} .if ${PORT_OPTIONS:MDOCS}
@${MKDIR} ${STAGEDIR}${DOCSDIR} @${MKDIR} ${STAGEDIR}${DOCSDIR}
${INSTALL_MAN} ${WRKSRC}/*.html ${STAGEDIR}${DOCSDIR} ${INSTALL_MAN} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.endif .endif
.include <bsd.port.mk> .include <bsd.port.mk>