Page MenuHomeFreeBSD
Differential D26412

Export TCP congestion control name
ClosedPublic
Actions

Authored by tuexen on Sep 12 2020, 2:03 PM.
Tags
None
Referenced Files
F132668341: D26412.id76960.diff
Sat, Oct 18, 10:02 PM
Unknown Object (File)
Sat, Oct 18, 6:56 AM
Unknown Object (File)
Sat, Oct 4, 8:53 PM
Unknown Object (File)
Sat, Oct 4, 3:03 AM
Unknown Object (File)
Sat, Oct 4, 2:06 AM
Unknown Object (File)
Fri, Oct 3, 5:03 PM
Unknown Object (File)
Fri, Oct 3, 8:31 AM
Unknown Object (File)
Fri, Oct 3, 5:37 AM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
rscheff
rrs
Group Reviewers
transport
Commits
rS365686: Export the name of the congestion control. This will be used by sockstat
Summary

Export the TCP congestion control name to userland. A separate commit will extend sockstat to display it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 33533

Event Timeline

tuexen created this revision.Sep 12 2020, 2:03 PM
Herald added a reviewer: transport. · View Herald TranscriptSep 12 2020, 2:03 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Sep 12 2020, 2:03 PM
Harbormaster completed remote builds in B33521: Diff 76945.Sep 12 2020, 2:03 PM
rscheff requested changes to this revision.Sep 12 2020, 9:14 PM
rscheff added inline comments.
sys/netinet/tcp_var.h
771

I suggest to move this string (of limited size) next to the other strings atop the struct.

This revision now requires changes to proceed.Sep 12 2020, 9:14 PM
tuexen updated this revision to Diff 76960.Sep 12 2020, 10:12 PM

Move CC name up as suggested by Richard.

Harbormaster completed remote builds in B33533: Diff 76960.Sep 12 2020, 10:12 PM
tuexen added inline comments.Sep 12 2020, 10:12 PM
sys/netinet/tcp_var.h
771

Done.

rscheff accepted this revision.Sep 12 2020, 10:25 PM
This revision is now accepted and ready to land.Sep 12 2020, 10:25 PM
Closed by commit rS365686: Export the name of the congestion control. This will be used by sockstat (authored by tuexen). · Explain WhySep 13 2020, 9:07 AM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS365686: Export the name of the congestion control. This will be used by sockstat.

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines
3 lines

Diff 76960

View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...