Page MenuHomeFreeBSD

Fix posixshmcontrol nits.
ClosedPublic

Authored by markj on Sep 9 2020, 3:41 PM.
Tags
None
Referenced Files
F166988127: D26376.id76816.diff
Tue, Aug 18, 10:13 AM
Unknown Object (File)
Sat, Aug 15, 5:42 PM
Unknown Object (File)
Wed, Aug 12, 4:49 PM
Unknown Object (File)
Wed, Aug 12, 4:48 PM
Unknown Object (File)
Wed, Aug 12, 3:50 PM
Unknown Object (File)
Tue, Aug 11, 10:21 AM
Unknown Object (File)
Mon, Aug 10, 11:23 AM
Unknown Object (File)
Sun, Aug 9, 10:58 AM
Subscribers

Details

Reviewers
kib
Group Reviewers
manpages
Commits
rS365749: Fix some posixshmcontrol nits.
Summary
  • Exit with an error if no path is specified.
  • Man page typo.
  • Error message typo.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33462
Build 30742: arc lint + arc unit

Event Timeline

markj requested review of this revision.Sep 9 2020, 3:41 PM
markj created this revision.

I do not object against returning error if subcommand is not specified, or if no path is given, but why ?

This revision is now accepted and ready to land.Sep 9 2020, 3:53 PM
In D26376#586472, @kib wrote:

I do not object against returning error if subcommand is not specified, or if no path is given, but why ?

The usage message implies that at least one path must be given. I think it is also more conventional to return an error instead of silently doing nothing, and it helps catch bugs (e.g., someone writes "posixshmcontrol create $foo" in a shell script but forgets to assign to foo). Indeed, I noticed because in some manual testing I made a similar mistake.

This revision was automatically updated to reflect the committed changes.