Page MenuHomeFreeBSD

Fix posixshmcontrol nits.
ClosedPublic

Authored by markj on Sep 9 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 10:33 PM
Unknown Object (File)
Mon, Oct 13, 12:24 PM
Unknown Object (File)
Fri, Oct 3, 5:35 AM
Unknown Object (File)
Sep 3 2025, 7:29 AM
Unknown Object (File)
Aug 23 2025, 8:01 AM
Unknown Object (File)
Aug 19 2025, 6:17 AM
Unknown Object (File)
Aug 6 2025, 2:41 PM
Unknown Object (File)
Aug 1 2025, 8:10 PM
Subscribers

Details

Reviewers
kib
Group Reviewers
manpages
Commits
rS365749: Fix some posixshmcontrol nits.
Summary
  • Exit with an error if no path is specified.
  • Man page typo.
  • Error message typo.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 9 2020, 3:41 PM
markj created this revision.

I do not object against returning error if subcommand is not specified, or if no path is given, but why ?

This revision is now accepted and ready to land.Sep 9 2020, 3:53 PM
In D26376#586472, @kib wrote:

I do not object against returning error if subcommand is not specified, or if no path is given, but why ?

The usage message implies that at least one path must be given. I think it is also more conventional to return an error instead of silently doing nothing, and it helps catch bugs (e.g., someone writes "posixshmcontrol create $foo" in a shell script but forgets to assign to foo). Indeed, I noticed because in some manual testing I made a similar mistake.

This revision was automatically updated to reflect the committed changes.