Page MenuHomeFreeBSD

Fix posixshmcontrol nits.
ClosedPublic

Authored by markj on Sep 9 2020, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 1:40 AM
Unknown Object (File)
Nov 11 2024, 3:15 PM
Unknown Object (File)
Nov 1 2024, 7:30 PM
Unknown Object (File)
Nov 1 2024, 7:30 PM
Unknown Object (File)
Nov 1 2024, 7:29 PM
Unknown Object (File)
Nov 1 2024, 7:07 PM
Unknown Object (File)
Oct 2 2024, 2:53 PM
Unknown Object (File)
Sep 27 2024, 10:59 AM
Subscribers

Details

Reviewers
kib
Group Reviewers
manpages
Commits
rS365749: Fix some posixshmcontrol nits.
Summary
  • Exit with an error if no path is specified.
  • Man page typo.
  • Error message typo.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 9 2020, 3:41 PM
markj created this revision.

I do not object against returning error if subcommand is not specified, or if no path is given, but why ?

This revision is now accepted and ready to land.Sep 9 2020, 3:53 PM
In D26376#586472, @kib wrote:

I do not object against returning error if subcommand is not specified, or if no path is given, but why ?

The usage message implies that at least one path must be given. I think it is also more conventional to return an error instead of silently doing nothing, and it helps catch bugs (e.g., someone writes "posixshmcontrol create $foo" in a shell script but forgets to assign to foo). Indeed, I noticed because in some manual testing I made a similar mistake.

This revision was automatically updated to reflect the committed changes.