Page MenuHomeFreeBSD
Differential D26303

www/firefox: Fix tab crashing when not using pulse-rust backend
ClosedPublic
Actions

Authored by khng on Sep 2 2020, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 3:45 AM
Unknown Object (File)
Tue, Dec 3, 4:29 PM
Unknown Object (File)
Sat, Nov 30, 4:31 AM
Unknown Object (File)
Nov 19 2024, 4:30 PM
Unknown Object (File)
Oct 29 2024, 7:03 PM
Unknown Object (File)
Oct 23 2024, 2:43 AM
Unknown Object (File)
Sep 30 2024, 2:05 AM
Unknown Object (File)
Sep 21 2024, 11:34 AM
View All Files
Subscribers
debdrup
khng
lwhsu
pete_nomadlogic.org
swills

Details

Reviewers
jbeich
Commits
rP548274: MFH: r548266
rP548266: www/firefox: fix tab crashing when not using pulseaudio
Summary

Revert 953d224e37c4 to workaround the issue of occational tab crashing when
using any cubeb backends other than pulse-rust to play media. The loss of such
change will be that users will not be able to do profiling on threads created by libcubeb.

Test Plan

To make it more easier to test, it is better to limit the number of concurrent process to 1-2. Then play a load of media in different tabs. Let Firefox run for a long period of time.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33358
Build 30667: arc lint + arc unit

Event Timeline

khng requested review of this revision.Sep 2 2020, 7:32 PM
khng created this revision.
Harbormaster completed remote builds in B33341: Diff 76559.Sep 2 2020, 7:32 PM
khng edited the test plan for this revision. (Show Details)Sep 2 2020, 7:34 PM
lwhsu added a subscriber: lwhsu.Sep 2 2020, 7:37 PM
debdrup added a subscriber: debdrup.Sep 2 2020, 7:41 PM
swills added a subscriber: swills.Sep 2 2020, 8:07 PM
jbeich added a comment.Sep 2 2020, 8:38 PM

Can you submit the change upstream? If you did rename the patch file after the bug.

khng added a comment.Sep 3 2020, 5:45 AM

At the mean time, the offending code was introduced in bug1647717.

khng updated this revision to Diff 76589.Sep 3 2020, 10:15 AM
  • Unregister as long as the stream ended peacefully
Harbormaster completed remote builds in B33356: Diff 76589.Sep 3 2020, 10:15 AM
khng updated this revision to Diff 76591.Sep 3 2020, 10:17 AM

Unregister as long as the stream ended peacefully

Harbormaster completed remote builds in B33358: Diff 76591.Sep 3 2020, 10:17 AM
khng added a comment.Sep 3 2020, 6:52 PM
In D26303#584645, @jbeich wrote:

Can you submit the change upstream? If you did rename the patch file after the bug.

I would try to seek feedback from upstream before moving in this direction.

khng added a comment.Sep 10 2020, 7:25 AM
In D26303#584976, @khng300_gmail.com wrote:
In D26303#584645, @jbeich wrote:

Can you submit the change upstream? If you did rename the patch file after the bug.

I would try to seek feedback from upstream before moving in this direction.

https://bugzilla.mozilla.org/show_bug.cgi?id=1664115

pete_nomadlogic.org added a subscriber: pete_nomadlogic.org.Sep 11 2020, 3:55 AM
khng updated this revision to Diff 76929.Sep 11 2020, 6:57 PM
  • sysutils/beats7: Update to 7.9.1
  • Update to the 20200906 snapshot of GCC 11.0.0.
  • Update to 1.1.0
  • Update to 1.0.7. This also fixes the -fno-common issue.
  • devel/intel-graphics-compiler: update to 1.0.4879
  • devel/gh: Update to 0.12.0
  • net-im/tut: Update to 0.0.17
  • New port: lang/hermes: JavaScript engine
  • Update to 6.4.167
  • - Update WWW
  • Update lang/erlang-runtime23 to version 23.0.4.
  • databases/pgrouting: Update to 3.1.0
  • editors/jucipp: Update to 1.6.1
  • Fix build on current.
  • graphics/gmt: Update to 6.1.1
  • - Reset MAINTAINER due to fatal bounces
  • devel/tortoisehg: Update to 5.5.1 and allow Python 3 by flavorizing the port. Switch to automatic plist.
  • devel/efl and x11-wm/enlightenment: Remove some files that I missed in the last update.
  • lang/intel-compute-runtime: update to 20.36.17813
  • devel/efl: Mark WAYLAND option BROKEN. Despite the code compiles, it is reported to fail on runtime.
  • math/pdal: Update to 2.2.0
  • Try to fix ports build.
  • Update to the 20200910 snapshot of GCC 8.4.1.
  • graphics/py-fiona: Update to 1.8.17
  • www/nextcloud: Update to 19.0.3
  • databases/virtualpg: Update to 2.0.0
  • www/firefox: Fix tab crashing when not using pulse-rust backend
Harbormaster completed remote builds in B33514: Diff 76929.Sep 11 2020, 6:57 PM
khng edited the summary of this revision. (Show Details)Sep 11 2020, 6:59 PM
khng added a comment.EditedSep 11 2020, 7:03 PM
In D26303#584645, @jbeich wrote:

Can you submit the change upstream? If you did rename the patch file after the bug.

Updated as suggested.

After reading the implementation of other cubeb backends such as WSAAPI, I decided to revert the offending changes instead.

Update: The reason behind reverting instead of patching is because some cubeb backends do really do data_callback and state_callback in different threads.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2020, 12:37 AM
Closed by commit rP548266: www/firefox: fix tab crashing when not using pulseaudio (authored by jbeich). · Explain Why
This revision was automatically updated to reflect the committed changes.
jbeich added a commit: rP548266: www/firefox: fix tab crashing when not using pulseaudio.
jbeich added a commit: rP548274: MFH: r548266.Sep 12 2020, 12:42 AM

Revision Contents
Changeset List

PathSize
www/
firefox/
2 lines
files/
44 lines

Diff 76591

View Options

www/firefox/Makefile

Loading...
View Options

www/firefox/files/patch-dom_media_AudioStream.cpp

Loading...