www/firefox: Fix tab crashing when not using pulse-rust backend

[khng]

Summary

Revert 953d224e37c4 to workaround the issue of occational tab crashing when
using any cubeb backends other than pulse-rust to play media. The loss of such
change will be that users will not be able to do profiling on threads created by libcubeb.

Test Plan

To make it more easier to test, it is better to limit the number of concurrent process to 1-2. Then play a load of media in different tabs. Let Firefox run for a long period of time.

[jbeich]

Can you submit the change upstream? If you did rename the patch file after the bug.

[khng]

At the mean time, the offending code was introduced in bug1647717.

[khng]

• Unregister as long as the stream ended peacefully

[khng]

Unregister as long as the stream ended peacefully

[khng]

In D26303#584645, @jbeich wrote:

Can you submit the change upstream? If you did rename the patch file after the bug.

I would try to seek feedback from upstream before moving in this direction.

[khng]

In D26303#584976, @khng300_gmail.com wrote:

In D26303#584645, @jbeich wrote:

Can you submit the change upstream? If you did rename the patch file after the bug.

I would try to seek feedback from upstream before moving in this direction.

https://bugzilla.mozilla.org/show_bug.cgi?id=1664115

[khng]

• sysutils/beats7: Update to 7.9.1
• Update to the 20200906 snapshot of GCC 11.0.0.
• Update to 1.1.0
• Update to 1.0.7. This also fixes the -fno-common issue.
• devel/intel-graphics-compiler: update to 1.0.4879
• devel/gh: Update to 0.12.0
• net-im/tut: Update to 0.0.17
• New port: lang/hermes: JavaScript engine
• Update to 6.4.167
• - Update WWW
• Update lang/erlang-runtime23 to version 23.0.4.
• databases/pgrouting: Update to 3.1.0
• editors/jucipp: Update to 1.6.1
• Fix build on current.
• graphics/gmt: Update to 6.1.1
• - Reset MAINTAINER due to fatal bounces
• devel/tortoisehg: Update to 5.5.1 and allow Python 3 by flavorizing the port. Switch to automatic plist.
• devel/efl and x11-wm/enlightenment: Remove some files that I missed in the last update.
• lang/intel-compute-runtime: update to 20.36.17813
• devel/efl: Mark WAYLAND option BROKEN. Despite the code compiles, it is reported to fail on runtime.
• math/pdal: Update to 2.2.0
• Try to fix ports build.
• Update to the 20200910 snapshot of GCC 8.4.1.
• graphics/py-fiona: Update to 1.8.17
• www/nextcloud: Update to 19.0.3
• databases/virtualpg: Update to 2.0.0
• www/firefox: Fix tab crashing when not using pulse-rust backend

[khng]

In D26303#584645, @jbeich wrote:

Can you submit the change upstream? If you did rename the patch file after the bug.

Updated as suggested.

After reading the implementation of other cubeb backends such as WSAAPI, I decided to revert the offending changes instead.

Update: The reason behind reverting instead of patching is because some cubeb backends do really do data_callback and state_callback in different threads.