Fix the build of scandir_b with GCC.
ClosedPublic
Actions

Authored by jhb on Aug 31 2020, 7:55 PM.

Tags

None

Referenced Files

	F132522950: D26256.id.diff
	Fri, Oct 17, 3:52 PM

	F132522949: D26256.id76439.diff
	Fri, Oct 17, 3:52 PM

	F132522948: D26256.id76430.diff
	Fri, Oct 17, 3:52 PM

	F132482077: D26256.diff
	Fri, Oct 17, 7:14 AM

	Unknown Object (File)
	Sun, Sep 28, 3:23 PM

	Unknown Object (File)
	Sun, Sep 28, 3:19 PM

	Unknown Object (File)
	Sun, Sep 28, 3:09 PM

	Unknown Object (File)
	Sun, Sep 28, 3:06 PM

Subscribers

Details

Reviewers

kib
adrian

Commits

rG939430f23771: Fix the build of scandir_b with GCC.
rS365012: Fix the build of scandir_b with GCC.

Summary

Use explicit typedefs for block thunk structures as in r264143.

Test Plan

this fixes the build of libc with both GCC 6 and GCC 9 after scandir_b was hooked up to the build

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 33266
Build 30597: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Aug 31 2020, 7:55 PM

jhb created this revision.

Harbormaster completed remote builds in B33266: Diff 76430.Aug 31 2020, 7:55 PM

Thanks! There's another _b.c file that isn't linked into the build yet that needs similar treatment.

This revision is now accepted and ready to land.Aug 31 2020, 8:05 PM

kib accepted this revision.Aug 31 2020, 8:59 PM

Closed by commit rS365012: Fix the build of scandir_b with GCC. (authored by jhb). · Explain WhyAug 31 2020, 9:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS365012: Fix the build of scandir_b with GCC..

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2020, 9:55 PM

rlibby added a commit: rG939430f23771: Fix the build of scandir_b with GCC..Dec 31 2020, 8:47 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

scandir.c

11 lines

Diff 76430

View Options

Fix the build of scandir_b with GCC.ClosedPublicActions