Update ypset(8) with the latest version from OpenBSD.
ClosedPublic
Actions

Authored by araujo on Aug 4 2015, 1:06 AM.

Details

Reviewers

• rodrigc
kib
allanjude
bapt

Summary

Sync the code with OpenBSD.
Remove 3rd BSD clause.

Test Plan

Test to set another NIS server:
araujo@coxinha:/usr/src/usr.sbin/ypset# ypset -d freebsd 10.0.1.14
ypset: Cannot ypset for domain freebsd on host 10.0.1.14: RPC: Program unavailable - make sure ypbind was started with -ypset or -ypsetme

araujo@coxinha:/usr/src/usr.sbin/ypset# ypset -d freebsd 10.0.1.14

araujo@coxinha:/usr/src/usr.sbin/ypset# ypwhich -x
"passwd" is an alias for "passwd.byname"
"master.passwd" is an alias for "master.passwd.byname"
"shadow" is an alias for "shadow.byname"
"group" is an alias for "group.byname"
"networks" is an alias for "networks.byaddr"
"hosts" is an alias for "hosts.byaddr"
"protocols" is an alias for "protocols.bynumber"
"services" is an alias for "services.byname"
"aliases" is an alias for "mail.aliases"
"ethers" is an alias for "ethers.byname"

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

araujo updated this revision to Diff 7627.Aug 4 2015, 1:06 AM

araujo retitled this revision from to Update ypset(8) with the latest version from OpenBSD..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added reviewers: • rodrigc, bapt.

Herald added a reviewer: manpages. · View Herald TranscriptAug 4 2015, 1:06 AM

Herald added a subscriber: imp. · View Herald Transcript

araujo added a reviewer: kib.Aug 4 2015, 1:07 AM

kib added inline comments.Aug 4 2015, 4:40 AM

usr.sbin/ypset/ypset.c
116	Why do you need these ? The extern declarations for the getopt(3) vars are provided by unistd.h.

Remove optarg and optind provided by unistd.h.
Spotted by @kib.

Thank you!

Herald edited edge metadata. · View Herald TranscriptAug 4 2015, 4:59 AM

bapt accepted this revision.Aug 9 2015, 9:51 PM

bapt edited edge metadata.

Hey Allan,

Could you please make a review on the manpage?

All the best.

allanjude added inline comments.Aug 10 2015, 2:33 PM

usr.sbin/ypset/ypset.8
77	This could be a little more clear that the change is actually being applied to a remote system "Change the YP binding of .Ar host , rather than that of the local machine."
usr.sbin/ypset/ypset.c
71	Is there a reason to change this away from bzero?
98	The whitespace looks off here
127	style(9) requires a space here. Just undo the whitespace change